FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.76k stars 406 forks source link

Stacked walls will stack their flooding and water flow rates when breached #13469

Open WJohn opened 8 months ago

WJohn commented 8 months ago

Disclaimers

What happened?

The Problem: When multiple walls are overlapping, damaging them will have them individually add flow rate to the room despite covering the same surface area of the hull. This can result in seemingly decorative stacked walls and hulls both contributing to flooding and causing much more extreme flooding when damaged.

In the following video (on 1.2.12.0 Unstable), the left wall would ordinarily flood at a flow rate of 543.7. The 1000 flow pump can handle this. The right wall has 5 walls stacked on top of each other, and will subsequently have a flow rate of 2718.5 despite being the exact same size of a breach.

https://github.com/FakeFishGames/Barotrauma/assets/5988156/248a6f1d-6291-49c4-81b8-1a26da0e1669

Expected Result: Breach flow rate should first be determined by the surface area of the hull block being affected by a breach, and secondly by the single most damaged wall affecting that section.

Notes:

Reproduction steps

  1. Enter the Submarine Editor
  2. Load the Orca 2
  3. Destroy the frontmost walls in front of the captain's Navigation Terminal
  4. Observe the flow rate
  5. Destroy the furthest back walls in the Engine Room
  6. Compare the flow rate with the breach in the Command Room

Bug prevalence

Happens every time I play

Single player or multiplayer?

Happens in both single player and multiplayer

-

No response

Version

v1.2.12.0 (unstable)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

Regalis11 commented 2 weeks ago

Fixed in https://github.com/FakeFishGames/Barotrauma-development/commit/f75dd4ecabe5449f66b060ade96741a057744975