FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.74k stars 403 forks source link

[Unstable] Cargo salvage missions spawning cargo in odd places #13753

Closed Regalis11 closed 6 months ago

Regalis11 commented 6 months ago

Discussed in https://github.com/FakeFishGames/Barotrauma/discussions/13736

Originally posted by **HawkinsThe71st** April 6, 2024 ### Disclaimers - [X] I have searched the issue tracker to check if the issue has already been reported. - [ ] My issue happened while using mods. ### What happened? While checking out the new cargo salvage missions I've noticed most of the time the cargo crates would spawn in odd places such as the middle of a sub or somewhere far away on the level. Unfortunately I did not save the level seeds where these issues occured but the issue seems fairly consistent. One instance where the cargo spawned under the level? ![image](https://github.com/FakeFishGames/Barotrauma/assets/115734437/cd2d8dba-5c20-49fa-95ff-bdc13fa0dfe6) One instance where the crate spawned in the middle of the Barsuk wreck: ![image](https://github.com/FakeFishGames/Barotrauma/assets/115734437/d418e80d-0d11-4a1e-8e2b-a9802cde96cb) Also the crate contained a traitor mode item, not sure if its an issue: ![image](https://github.com/FakeFishGames/Barotrauma/assets/115734437/d1f4e0d7-3e5f-41c5-ac18-5a37da1ba9ed) One instance where the cargo spawned off to the right side of the level: ![image](https://github.com/FakeFishGames/Barotrauma/assets/115734437/fb225a49-6df6-4771-b5f2-7b0e945e6fdd) Another instance of the cargo spawning in odd location: https://github.com/FakeFishGames/Barotrauma/assets/115734437/b24ed584-0a7b-4c0b-8d9e-c44c500141fb At first I thought it might be due to some wrecks not having crate shelves but I had this instance where the cargo spawned someplace else in the level despite the wreck having shelves: ![image](https://github.com/FakeFishGames/Barotrauma/assets/115734437/e19f2879-b28e-49f1-ae3f-2e8605576ffa) Even the artifact variant didn't spawn in the wreck: ![image](https://github.com/FakeFishGames/Barotrauma/assets/115734437/dab47387-d286-481c-923f-477d941a4c63) ### Reproduction steps 1. Start a cargo salvage mission in a campaign 2. Go to cargo mission marker ### Bug prevalence Happens regularly ### Single player or multiplayer? Single player ### - _No response_ ### Version v1.4.0.0 (unstable) ### - _No response_ ### Which operating system did you encounter this bug on? Windows ### Relevant error messages and crash reports _No response_
Regalis11 commented 6 months ago

Save where this should be reproducible: lost cargo test 2 (1).zip

Regalis11 commented 6 months ago

Hopefully fixed in https://github.com/FakeFishGames/Barotrauma-development/commit/e265e0e50ce9e51d8ab24fdeb00009550a54074e

Jasontti commented 6 months ago

Tested in: https://github.com/FakeFishGames/Barotrauma-development/pull/5144/commits/e265e0e50ce9e51d8ab24fdeb00009550a54074e

Tested the save included, new missions in SP and MP campaign and Mission mode in MP Went through old and new salvage missions.

No issues found Closing ticket