FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.74k stars 403 forks source link

Infinite missions upon reloading #13880

Closed Regalis11 closed 5 months ago

Regalis11 commented 5 months ago

Discussed in https://github.com/FakeFishGames/Barotrauma/discussions/13879

Originally posted by **RooneyRoll** April 28, 2024 ### Disclaimers - [X] I have searched the issue tracker to check if the issue has already been reported. - [ ] My issue happened while using mods. ### What happened? When all the possible missions are taken from an outpost if I save and then load the game the mission giving npc have new set of missions which I am able to accept. ### Reproduction steps 1. Dock and arrive at a station or outpost 2. Go to the top and get the missions you can choose from 3. Save and quit the game 4. Load the game and repeat from step 2. ### Bug prevalence Happens every now and then ### Single player or multiplayer? Single player ### - _No response_ ### Version v1.4.5.0 (Blood in the Water Update, hotfix 1) ### - _No response_ ### Which operating system did you encounter this bug on? Linux ### Relevant error messages and crash reports _No response_
Regalis11 commented 5 months ago

Fixed in https://github.com/FakeFishGames/Barotrauma-development/commit/1f0383b2e92b197ab073d8ebc56840a295a9f918

Rokvach commented 5 months ago

Tested, in both singleplayer and multiplayer the fix does work if you leave the first outpost, but if you stay or even return to the first outpost you will still get infinite missions by saving and quitting. Moving back to main board ToDo.

Jasontti commented 5 months ago

Tested in: https://github.com/FakeFishGames/Barotrauma-development/pull/5257/commits/9549eb3bcb85ce5f0a7d6d9188e73059cf5de5c3

Tested in SP and MP Tested steps provided tested in couple outposts saved before accepting all missions saved before accepting missions

Could not replicate issue that Rockvach, but don't see that it was adressed in between. Maybe this was moved to QA by mistake?

itchyOwl commented 5 months ago

Not sure what you mean, it was addressed in that commit.

Jasontti commented 5 months ago

My mistake, no issues found. Closing as completed.