Modlist Improvements - Githubissues

FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.

http://www.barotraumagame.com/

1.73k stars 403 forks source link

Modlist Improvements #13933

Closed Jade-Harleyy closed 4 months ago

Jade-Harleyy commented 5 months ago

This PR:

Adds options for renaming and deleting local mods.
Adds an option to copy a workshop mod to a local mod.
Fixes the context menu's "unsubscribe" button not working.
Cleans up context menu creation code, hopefully making it easier to read and work with.
Adds methods to the Barotrauma.IO.Directory class to allow for copying and moving directories.

New Localization Tags:

RenamePackage - Rename
CopyWorkshopToLocal - Copy to local
DeleteMods - Delete Local Mods
DeleteModsConfirm - Are you sure you want to delete [amount] mod[plural]?\nThis cannot be undone!

mygamingaccount commented 4 months ago

Reviewing:

when I try to rename a mod to the same name, it gives me an error (A local package with the name or directory "Modname" already exists) instead of ignoring the change
rename text box overlaps with the "Cancel" button

mygamingaccount commented 4 months ago

I cherry picked this and now it feels awful when Baro updates and this feature is not there

Regalis11 commented 4 months ago

Are you sure you want to delete [amount] mod[plural]?\nThis cannot be undone!

This will not work in all languages, plurals don't work the same way as they do in English (adding an s to the end) in every language. For example, in Finnish the singular here would be "modin" and the plural would be "modia", and in many languages the rest of the sentence needs to change too when the word is in plural.

TextManager.Get("RenamePackage") + $" {mod.Name}"

This also doesn't work properly. The name of the mod may need to come before the "RenamePackage" word in some languages, and not all languages put a space between the words.

Regalis11 commented 4 months ago

I addressed the localization issues myself and moved this to a PR in our private repo. Thank you for your contribution once again! :)