FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.67k stars 394 forks source link

Items with light components add the 'light' tag to normal instead of predefined tags #14038

Closed Regalis11 closed 1 month ago

Regalis11 commented 1 month ago

Discussed in https://github.com/FakeFishGames/Barotrauma/discussions/13968

Originally posted by **Jade-Harleyy** May 16, 2024 ### Disclaimers - [X] I have searched the issue tracker to check if the issue has already been reported. - [X] My issue happened while using mods. ### What happened? When placing an item that has a LightComponent into the sub editor, it automatically adds the `light` tag to the item's _normal_ tags instead of its predefined tags, allowing it to be removed. ### Reproduction steps 1. Open the submarine editor. 2. Place a "Light Component" item. 3. Observe the item's tags. ### Bug prevalence Happens every time I play ### Single player or multiplayer? Other ### - Submarine Editor ### Version v1.4.6.0 (Blood in the Water Update, hotfix 2) ### - _No response_ ### Which operating system did you encounter this bug on? Windows ### Relevant error messages and crash reports _No response_
Regalis11 commented 1 month ago

Fixed in https://github.com/FakeFishGames/Barotrauma-development/pull/5345/commits/53088bead6f53f414bd4b3685957f9dcfde5144f

Rokvach commented 1 month ago

Tested, working correctly. Can be merged and closed.