search

FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.75k stars 407 forks source link

Biome ambient sounds aren't affected by sound volume, always plays #7070

Closed Rokvach closed 3 years ago

Rokvach commented 3 years ago

Repro steps:

  1. Boot up a round and leave the outpost
  2. Once round loads turn sound and music volumes to 0
  3. Increase your PC audio volume (Max to really hear it)
  4. Notice that the biome ambient sound still plays
  5. Adjust sound volume and notice that the biome ambient sound doesn't change
ekqvist commented 3 years ago

Should be fixed in Regalis11/Barotrauma-development@af2e575

ekqvist commented 3 years ago

Accidentally tied it back to the music volume, should now be fixed in Regalis11/Barotrauma-development@7461aa9 and correctly tied to the sound volume.

ekqvist commented 3 years ago

Now that it's actually tied to the sound volume, you could test how the current volume level seems. To me, it felt it could perhaps be a bit louder (the volume is now set to 0.25), but you could give a second opinion on that. Maybe I'm wrong.

Rokvach commented 3 years ago

I think the volume is fine, we've got some complaints of players not liking the white noise that some of the biome tracks has, but that was mainly due to this bug most likely as the volume was constant. But working correctly, closing.