FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.75k stars 405 forks source link

[0.15.16.0] Bot returning to sub from outside while holding a crate is doing some twitchy thing with crate #7508

Closed Kaillera closed 2 years ago

Kaillera commented 2 years ago

Description Twitchy

Steps To Reproduce

  1. Have a crew member outside with a diving suit and a crate.
  2. Tell him to follow you (while you're inside the sub).

Version 0.15.16.0

Regalis11 commented 2 years ago

I'm afraid I couldn't reproduce this. Did it happen in multiplayer or singleplayer? https://user-images.githubusercontent.com/14351070/144058691-9556322e-6a52-4e6a-9f56-27e6042479d0.mp4

Kaillera commented 2 years ago

Singleplayer. I'll see if it's still happening later.

Kaillera commented 2 years ago

Save.zip

So it's still happening on this save.

1) Control the Captain, put on a suit, and pick up a crate. 2) Exit the sub and gain some distance away from the sub. 3) Set the Captain to Wait 4) Use another character in the submarine and tell the Captain to Follow 5) He should be twitching the crate as he comes back into the sub.

Regalis11 commented 2 years ago

Thank you! I managed to fix this now (https://github.com/Regalis11/Barotrauma-development/commit/7a49bc6ca58c9311e233bd209c18f8a121e0eb0d). Turns out the problem was the underwater scooter: the bot was trying to equip it, which caused it to drop the crate and immediately pick it up again.

For testing, this is probably the easiest way to repro the issue:

  1. Have a crew member outside with a diving suit and a crate, and an underwater scooter in their inventory.
  2. Tell him to follow you (while you're inside the sub).
Rokvach commented 2 years ago

Tested, working correctly. Closing.