FakeFishGames / Barotrauma

A 2D online multiplayer game taking place in a submarine travelling through the icy depths of Jupiter's moon Europa.
http://www.barotraumagame.com/
1.76k stars 406 forks source link

did not receive STARTGAMEFINALIZE message #7896

Closed fire-bot closed 2 years ago

fire-bot commented 2 years ago

Sent by WordPress (issue@barotraumagame.com). Created by fire.


From: TheHappySerpent

Description playing with mods, i personally dont think this is a base game baro issue, but i was told to submit it so im going ahead and doing that

me and my friends are playing with a decent amount of mods, we will randomly (usually after first leaving the station in campaign) get the following error:

Error while starting round (did not recieve STARTGAMEFINALIZE message from the server). Stopping the round... TimedOut Couroutine "Barotrauma.Networking.GameClient+d__93" has failed

After getting this error, i go to validate the files through steam, and it returns having 3 files which failed to validate, which steam proceeds to reaquire

But after attempting to reload that save file the error had occured on, the error occurs again.

Not quite certain what files are going missing, corrupting, or whatever.

Creating a new save tends to work, atleast, until the bug shows up again, which it always eventually does.

Steps To Reproduce Start a game with the mods listed below, may have to play for a while for it to show up

IT IS ENTIRELY POSSIBLE THAT THIS BUG MAY NOT BE LINKED TO A MOD, AND MORE SO LINKED TO THE QUANTITY OF MODS. (i will be testing this myself)

Currently running the mods:

New Wrecks for barotrauma gunlights updated Deep Sea Alchohol Huskmod Unitload device - 12 crates Genes+ Shreksophone EK Armory Nerfs Baroplus Stations from beyond T.I.T.A.N. power suit Barotraumatic (and its dependencies as listed on steam) ADV Beacon stations EK Utilities EK Armory EK Dockyard EK Gunnery Instrumental music addon Custom Icons Visual Variety Pack Meaningful CPR No Role Balance Normal Health Outpost NPCs Stunnerffix crouch harder spoils of the hunt Dynamic Europa Backpacks

Version 0.15.22.1

Operating System Windows

--

This issue was sent from a contact form on https://barotraumagame.com/bug

Ek-Videogames commented 2 years ago

Just want to add that this mission-start / mid-round join problem can happen on entirely vanilla servers as well so... 🤷‍♂️your guess is as good as mine there.

Edit:

So, all other tickets regarding this issue #4183 seemed to have been closed on May 25th - under assumption that because it has not been reported as much the issue no longer exists.

Also found a screencap of the same error recording dated at Nov 6th - while that was before the most recent set of updates, its still alot later than May. So re-confirming this bug? image

reductorian commented 2 years ago

This is my discussion post on Steam about my recent experience with this bug. https://steamcommunity.com/app/602960/discussions/1/3199244571750319157

Seems to be the same problem. One thing I forgot to mention: playing with 1 mod (Vertical Hatches), but submarine doesn`t use these hatches, just needs the mod (was made with mod on, maybe). And the submarine is a custom-made and heavy. Copying the text here.

So how this looks like. 1) When I am already at a lobby and the game is about to start, then after a loading screen (and a sound of moving airlock door) there is a pause... 20 seconds or so... then i`m back in the lobby, but the game started. 2) When already in game and detaching from the outpost with some missions to try and finish them, there is a pause... and read above.

In both cases on my side (client) texts of location name, mission names, about-mission popups appear as normal above the lobby screen. Lower-right button suggests for me to connect as a spectator, and when I try, button "clicks" to gray color, but nothing happens. Also console appears, as if f3 was pressed, and the next is written in red:

_Error while starting the round (did not recieve STARTGAMEFINALIZE message from the server). Stopping the round... TimedOut Coroutine "Barotrauma.Networking.GameClient+d_93" has failed

When I further try to reconnect and enter the game, restart and reconnect, or fully (with AppData and Steam folders of game deleted) reinstall and reconnect to server at this state, result stays the same, minus popups or loading screens. It happened on Windows 7 SP2 before, and it happens on Windows 10 (different PC) where, I suppose, all updates are up to date. Server at the meantime suggests that I, myself, disconnected the first time I failed to enter game. Also if server restarts itself (campain mode, same mission status), it changes nothing for my trying to connect and play a game.

So here is a fun part. We`ve done some experiments on why this happens and there is, apparently, some connection to the sort of missions currently active for this round of campain on server side. For example:

  • when no missions selected, there are no connection problems. 90% sure about that. Connections to the outpost are successifull everytime.
  • when missions are selected, if there are too many, error happens. 3 active missions (maybe beacon missions are not included) is enough and I can`t enter the game.
  • when missions are selected, there are SOME of them which 100% deny me the game. Those are some of new update (or two updates?) missions, such as: destroy pirate sub, clean alien ruin guards, transfer people from A to B, and maybe some more.
  • also when something happens at the outpost, there is a chance I wont be able to connect as well. This was an new event for me (terror husk attack), so maybe it is also from the new updates. Lost outpost location plays without problems. Heals by server`s side: reconnection to the outpost, mission failure, clean sheet of missions and so I enter without problems.

There is also a chance this situation is somehow possible due to VPN. Server uses Wi-fi connection, and so does client on his side. So for that client - who uses the same Wi-fi - this problem NEVER occures. But for me, using another net to connect, problem appears. Thing is, if it appears for me one time, and other time it can be avoided by not using parts of the game, it is very likely game's fault. If I`m wrong, I will gladly accept support for this problem.

reductorian commented 2 years ago

Update on a problem^

This issue has been avoided completely by doing next steps:

Still it is a game problem. I would like to see it`s been removed. I am not the only one having this problem after all.

Regalis11 commented 2 years ago

We unfortunately still haven't been able to figure out what's causing this (or a way to reproduce it reliably). :/

If anyone has a campaign save where this occurs consistently, it'd most likely help us a lot in diagnosing this.

I also added some extra debug logging in https://github.com/Regalis11/Barotrauma-development/commit/8d6cface69ab9728b53597a3e6222c40eaef7368 to hopefully diagnose this: the server should now show a warning when it fails to respond to a client's STARTGAMEFINALIZE request (if that's where the problem is, which might not be the case, but it's the best guess I can come up with). The clients should also display some extra information in the debug console when waiting for the STARTGAMEFINALIZE message. The extra logging will be included in the next unstable build.

ghost commented 2 years ago

I and my friend have encountered this issue and now we cannot continue our campaign.

If anyone has a campaign save where this occurs consistently, it'd most likely help us a lot in diagnosing this.

Where can I upload this save?

I will upload the logs as well with the save.

@Regalis11

Regalis11 commented 2 years ago

@Dormouse759 You could post it here on GitHub. Note that you need to .zip it first because GitHub doesn't allow attaching files with the .save file extension. Sorry for the trouble and thanks for trying to help us fix this!

ghost commented 2 years ago

saves.tar.gz

The logs don't seem to contain any useful information on the game data, only chat messages, seed, and mission types, which are already conatined in the save.

Am I searching wrong? /path/to/installation/Barotrauma/ServerLogs/

EDIT: We worked around the issue by swapping host. Now we can play alright. It might be helpful to note that my friend has faster loadings than I do.

Ek-Videogames commented 2 years ago

Just popping in to give confirmation update that this bug still occurs on the current stable build of "Rising Tides Update" v0.16.7.0

Edit: MORE-verbose client-side logging might be appreciated. after all, if you guys want to get more information then we'll need a way to get it in the first place.

Regalis11 commented 2 years ago

Addressed in https://github.com/Regalis11/Barotrauma-development/commit/68ebe347213bf3a9fec28e0ff6bd9cacf60a4ad1

Rokvach commented 2 years ago

Tested using the new command to stall loading times, I wasn't able to break the lobby nor my save when testing and players didn't disconnect while loading into a round. So this issue is working correctly, closing.