"Good quality" items start at very low skill requirements

[ubertpendragon]

Disclaimers

• [X] I have searched the issue tracker to check if the issue has already been reported.
• [ ] My issue happened while using mods.

What happened?

You get "Good quality" items as soon as you unlock the skill requirement craft them

As low as 20 skill is enough to get good quality: Excellent quality requires 100 skill

Increase the requirements for good quality to a halfway point or at least 50?

Version

0.18.12.0

[Regalis11]

Addressed in https://github.com/Regalis11/Barotrauma-development/commit/ed6cb18618189c81d72ce553be9c0a5558fd27f5

[ubertpendragon]

ed6cb18618: Changed the quality calculations for fabricated item: the character's skills need to be x2 the skill requirement of the fabricated item, instead of equal to or higher, to create a good quality item (Regalis11/Barotrauma#9467)

Some items have requirements 50 and above so you can't get them to "Good" before Excellent (or even capping skills?).

Here's the complete list for all above 50 (with numbers):

-Frag grenade 60 -EMP grenade 50 -C4 70 -IC4 50 -Compound N 60 -Fulgurium rod 70 -Volatile Fulgurium rod 70 -Assault Rifle 65 -Autoshotgun 65 -Handcannon 60 -Rapid Fissile Accelerator 65

Do a flat +20 skill check for Good, reduce requirements to 60 max?

[Regalis11]

That's a very good point. Changed the calculations again in https://github.com/Regalis11/Barotrauma-development/commit/899eeb1b651268101406cc703f3dc65d96eda0c8

Changed the fabrication quality calculations again: requiring x2 the min skill doesn't work with items whose min skill is 50 or more. Now the skill needs to be a flat 20 more than the min skill, capped to 100.

[Krzeszny]

capped to 100

To prevent future bugs, I suggest making sure if you haven't already, that (modded) items with 80+ skill requirement will be Excellent/Masterwork. I also suggest checking what would happen if an item required 100 skill.

(On a personal note, +20 skill is a somewhat high requirement for +10%, especially for items that already need 70+ skill to fabricate.)

[Tsunder]

What about linear interpolation / lerp from crafting requirement to 100? ^_^

[Regalis11]

Good points. I decided to change this once more: now the limit is 20% from the minimum skill requirement towards 100 (or in other words, skillRequirement = MathHelper.Lerp(skill.Level, MaxCraftingSkill, 0.2f)).

[Rokvach]

Tested, working correctly. Closing.