Introduce the Color provider for "pl_PL" locale

FakerPHP / Faker

Faker is a PHP library that generates fake data for you

https://fakerphp.github.io

Other

3.49k stars 331 forks source link

Introduce the Color provider for "pl_PL" locale #657

Closed d1823 closed 1 year ago

d1823 commented 1 year ago

What is the reason for this PR?

[x] A new feature
[ ] Fixed an issue (resolve #ID)

Author's checklist

[x] Follow the Contribution Guide
[x] New features and changes are documented

Summary of changes

This PR introduces a dedicated Color provider for the "pl_PL" locale.

Review checklist

[ ] All checks have passed
[ ] Changes are approved by maintainer

pimjansen commented 1 year ago

tests are missing

d1823 commented 1 year ago

I've added some tests based on the existing - french - color test cases.

pimjansen commented 1 year ago

I've added some tests based on the existing - french - color test cases.

Yeah its hard to test since it has datalists but since we use seeds it will always return the same result. So in this case we are sure it keeps running like this and that there are atleast no sidefx