search

FakerPHP / Faker

Faker is a PHP library that generates fake data for you
https://fakerphp.github.io
Other
3.49k stars 331 forks source link

Fix: gitignore .idea and .vscode #662

Closed edgarsn closed 1 year ago

edgarsn commented 1 year ago

What is the reason for this PR?

This helps to prevent from accidentally pushing IDE files while contributing to this repo.

Author's checklist

Summary of changes

Added /.idea/ and /.vscode/ to .gitignore file to fix that.

Review checklist

GrahamCampbell commented 1 year ago

These belong in your global gitignore file. It doesn't make sense for projects to duplicate this for each persons choice of OS and editor.

pimjansen commented 1 year ago

@GrahamCampbell do you know for any chance if there is an action to check this? It could help us to decline builds if stuff gets there

GrahamCampbell commented 1 year ago

I usually find that stuff is pretty easy to spot by eye when reviewing PRs.

pimjansen commented 1 year ago

I usually find that stuff is pretty easy to spot by eye when reviewing PRs.

Fair but was just curious 👌🏻