FakerPHP / Faker

Faker is a PHP library that generates fake data for you
https://fakerphp.github.io
Other
3.49k stars 331 forks source link

added Yemen Provider #665

Closed zayedadel closed 10 months ago

zayedadel commented 1 year ago

What is the reason for this PR?

to be used in yemen specific projects

Author's checklist

Summary of changes

addressFormats()

is returned from the following function

/**
 * @example 'اليمن الامانة شارع السبعين'
 */
public static function yemenAddress()
{
    $country = 'اليمن';
    $governorate = static::randomElement(static::$governorates);
    $subdivision = static::randomElement(static::$subdivisions[$governorate]);
    $precinct = static::randomElement(static::$precincts[$subdivision]);

    return $country . ' محافظة ' . $governorate . ' مديرية ' . $subdivision . ' منطقة ' . $precinct;
}
can be found in Address Class

the rest of changes are cultural and country specific terms nothing major 

Review checklist

zayedadel commented 1 year ago

last pull will hopefully pass all tests @localheinz

GlennM commented 1 year ago

Thanks for your effort, but I believe that new features are blocked until Faker 2.0 has been released?

zayedadel commented 1 year ago

@GlennM Ok no problem i'll wait until then before i do an other pull request. sorry for the inconvenience.

stale[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

zayedadel commented 11 months ago

@localheinz should i create another pull request or wait until v2.0 or what exactly is the situation ?