Fix: sk_SK street names

FakerPHP / Faker

Faker is a PHP library that generates fake data for you

https://fakerphp.github.io

Other

3.49k stars 331 forks source link

Fix: sk_SK street names #675

Closed devicebusy closed 8 months ago

devicebusy commented 11 months ago

What is the reason for this PR?

Fixed an issue with sk_SK street names generation (resolve #672)

Author's checklist

[x] Follow the Contribution Guide
[x] New features and changes are documented

Summary of changes

Added a list of real SK streets, fixed street name format

Review checklist

[ ] All checks have passed
[ ] Changes are approved by maintainer

pimjansen commented 11 months ago

Please review the contribution guide (see pr template)

localheinz commented 10 months ago

@pimjansen

This looks good to me - do you have any objections?

pimjansen commented 10 months ago

@pimjansen

This looks good to me - do you have any objections?

The code itself looks ok but i'd rather see the locale contents covered by a test

stale[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

MilosM33 commented 6 months ago

@pimjansen Hello, I'd like to reopen and finalize this Pull Request. What specific test would you like to see?