FakerPHP / Faker

Faker is a PHP library that generates fake data for you
https://fakerphp.github.io
Other
3.49k stars 331 forks source link

Add zh_TW cell phone and county / dist #682

Closed asika32764 closed 7 months ago

asika32764 commented 11 months ago

What is the reason for this PR?

Author's checklist

Summary of changes

Currently Zh_TW provider has 2 problems:

  1. The Address merged county & dist in one city() method and impossible to separate calls them.
  2. The PhoneNumber merged local number and cell phone number into one phoneNumber().

The PR try to separate them to different methods.

Review checklist

pimjansen commented 11 months ago

Please review the contribution guide!

asika32764 commented 11 months ago

Tests and documentation done. https://github.com/FakerPHP/fakerphp.github.io/pull/90

Any further changes required?

stale[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

asika32764 commented 6 months ago

@localheinz @pimjansen Will this PR be merged or any further works required?