Fix: Switch order of parameters

FakerPHP / Faker

Faker is a PHP library that generates fake data for you

https://fakerphp.github.io

Other

3.48k stars 332 forks source link

Fix: Switch order of parameters #703

Closed localheinz closed 10 months ago

localheinz commented 10 months ago

What is the reason for this PR?

[x] switches the order of parameters passed to ContainerBuilder::add()

Follows #702.

Author's checklist

[x] Follow the Contribution Guide

Summary of changes

Review checklist

[x] All checks have passed
[ ] Changes are approved by maintainer

pimjansen commented 10 months ago

This is pretty much a BC? I do not think it is wise at this point?

I'd rather just focus on the 2.x scooe tbh

localheinz commented 10 months ago

@pimjansen

It's not a BC break, see

https://github.com/FakerPHP/Faker/blob/cf1fd79881e9673aba3ecbe652081d4480914529/src/Faker/Container/ContainerBuilder.php#L18

The changes follow #702 - the previous order of parameters was awkward, and this pull request fixes it. It's somewhat related to preparations for 2.0.0.

localheinz commented 10 months ago

Thank you, @bram-pkg and @pimjansen!