issues
search
FakerPHP
/
Faker
Faker is a PHP library that generates fake data for you
https://fakerphp.github.io
Other
3.58k
stars
345
forks
source link
Fix: Do not memoize invalid service
#709
Closed
localheinz
closed
1 year ago
localheinz
commented
1 year ago
What is the reason for this PR?
[x] asserts that
Container::get($id)
throws a
RuntimeException
on the second attempt of retrieving a service that does not resolve to an
Extension
[x] stops memoizing the resolved service before inspecting whether it has resolved to an
Extension
Author's checklist
[x] Follow the
Contribution Guide
Summary of changes
Review checklist
[x] All checks have passed
[ ] Changes are approved by maintainer
What is the reason for this PR?
Container::get($id)
throws aRuntimeException
on the second attempt of retrieving a service that does not resolve to anExtension
Extension
Author's checklist
Summary of changes
Review checklist