Improve address provider for en_NG locale

chrisidakwo commented 7 months ago

What is the reason for this PR?

To improve the address data generated for the en_NG locale.

[ ] A new feature
[ ] Fixed an issue (resolve #ID)

Author's checklist

[x] Follow the Contribution Guide
[x] New features and changes are documented

Summary of changes

Renamed 'Abuja' to 'Federal Capital Territory'. Abuja is the name of a city and government administration area, but not a state.
Postcodes in Nigeria are strictly made up of 6 digits. The $postcode variable has been updated to reflect that.
Updated 'county' to act as an alias of 'state' - which is the actual term used to refer to the major sub-administrative governments directly below the Federal.
City names in Nigeria do not require a suffix. Hence, the array has been left empty.
It's common to see street names in Nigeria with prefixes such as 'Chief', 'General', 'Rev.', 'Bishop'. The street name format has been updated to reflect this.
'Region' in Nigeria typically refers to the political regional divisions of the country, and not cities. Hence, cityName has been added (instead) to reflect actual city names, and region has been updated to reflect the political regional divisions of Nigeria.

Review checklist

[ ] All checks have passed
[ ] Changes are added to the CHANGELOG.md
[ ] Changes are approved by maintainer

bram-pkg commented 7 months ago

Seems there are backwards compatible breaking changes, could you look at those?

bram-pkg commented 7 months ago

Just some PHPStan errors left now, seems you can remove those from the baseline

stale[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

FakerPHP / Faker