search

FakerPHP / Faker

Faker is a PHP library that generates fake data for you
https://fakerphp.github.io
Other
3.47k stars 330 forks source link

Add docblocks #869

Closed mokhosh closed 3 months ago

mokhosh commented 3 months ago

What is the reason for this PR?

These two methods are available in fa_IR, but they are not suggested or recognized by IDEs because they are not in the phpdocs.

This PR adds them to the phpdocs for better IDE support.

Author's checklist

Review checklist

pimjansen commented 3 months ago

They are specific for a locale and not globally. Therefor they are not in the generator

mokhosh commented 3 months ago

there's no way to add phpdocs for a specific provider, right?

just put up with lack of completion?

pimjansen commented 3 months ago

Indeed there is no way for the current implementation instead of typing it manually