FakerPHP / Faker

Faker is a PHP library that generates fake data for you
https://fakerphp.github.io
Other
3.47k stars 330 forks source link

Update Image.php #881

Open ngdream opened 2 months ago

ngdream commented 2 months ago

i fixed some bug in faker image provider

What is the reason for this PR?

Author's checklist

Summary of changes

Review checklist

pimjansen commented 1 month ago

I would easier consider this as unsecure though to not verify the handshake of an external resource

ngdream commented 1 month ago

I would easier consider this as unsecure though to not verify the handshake of an external resource

I would easier consider this as unsecure though to not verify the handshake of an external resource

This security prevented me and other developers from retrieving images using $faker->image() and I spent days trying to figure out how to fix this error

just check these links https://stackoverflow.com/questions/72454513/how-to-generate-and-download-images-in-storage-using-laravels-faker

https://stackoverflow.com/questions/72585447/trouble-with-faker-class-in-laravel

https://stackoverflow.com/questions/57589055/images-created-with-factory-faker-get-deleted-when-stored-in-storage-public-imag

ngdream commented 1 month ago

the solution i propose is in the last link

ngdream commented 1 month ago

@pimjansen please could you please give your opinion

the solution i propose is in the last link

@pimjansen please could you give your opinion about this ??

pimjansen commented 1 month ago

The image provider is deprecated and we wont fix it. Add your own custom provider if needed.

The proposed solution is not acceptable because it is not acceptable not to verify ssl peers