FakerPHP / Faker

Faker is a PHP library that generates fake data for you
https://fakerphp.github.io
Other
3.47k stars 330 forks source link

remove gmail.com.au from free email domains. #885

Open da-mask opened 1 month ago

da-mask commented 1 month ago

What is the reason for this PR?

freeEmail() function for AU provider included the domain gmail.com.au, which does not exist. It causes failing tests when validating emails with email:rfc,dns

Author's checklist

Summary of changes

Removed the errant domain from the en_AU/Internet provider file

Review checklist

pimjansen commented 1 month ago

Im not sure im a fan of this @bram-pkg since Faker only creates "valid structure" but never valid content. In fact the email address is valid. I think the problem is that a lookup is done on the domain. In fact i think most providers have the same problem in this case since . probably also does not exist

bram-pkg commented 1 month ago

We have safe email for that I imagine, the email providers array should at least contain valid domains don't you think?

pimjansen commented 1 month ago

We have safe email for that I imagine, the email providers array should at least contain valid domains don't you think?

Well it is valid but non existing. There is nothing wrong with the domain itself

da-mask commented 1 month ago

I think free emails should return actual free emails, not non existent ones.

bram-pkg commented 1 month ago

I must agree with @da-mask here. It should return known good email domains to register on for free.

da-mask commented 1 month ago

I'm not sure if you require further action from me?

bram-pkg commented 1 month ago

@pimjansen I don't know what's going on with BC Roave, do you know how to fix?

pimjansen commented 1 month ago

@pimjansen I don't know what's going on with BC Roave, do you know how to fix?

We need to allow them with regex. Those in Core are acceptable since there is a non BC promise but those provider issues are bad though.