Open da-mask opened 1 month ago
Im not sure im a fan of this @bram-pkg since Faker only creates "valid structure" but never valid content. In fact the email address is valid. I think the problem is that a lookup is done on the domain. In fact i think most providers have the same problem in this case since
We have safe email for that I imagine, the email providers array should at least contain valid domains don't you think?
We have safe email for that I imagine, the email providers array should at least contain valid domains don't you think?
Well it is valid but non existing. There is nothing wrong with the domain itself
I think free emails should return actual free emails, not non existent ones.
I must agree with @da-mask here. It should return known good email domains to register on for free.
I'm not sure if you require further action from me?
@pimjansen I don't know what's going on with BC Roave, do you know how to fix?
@pimjansen I don't know what's going on with BC Roave, do you know how to fix?
We need to allow them with regex. Those in Core are acceptable since there is a non BC promise but those provider issues are bad though.
What is the reason for this PR?
freeEmail()
function for AU provider included the domaingmail.com.au
, which does not exist. It causes failing tests when validating emails withemail:rfc,dns
Author's checklist
Summary of changes
Removed the errant domain from the en_AU/Internet provider file
Review checklist
CHANGELOG.md