search

Fakerr / git-recall

An interactive way to peruse your git history from the terminal
MIT License
2.12k stars 47 forks source link

Doesn't work in rxvt; just reprints list of commits #11

Open yggdr opened 7 years ago

yggdr commented 7 years ago

In rxvt-unicode 9.22 on FreeBSD 11.0 (using zsh and /bin/sh) git recall prints the commits, but hitting j/k/Up/Down just prints out the same commits once more. No commit is marked like in the gif at any time. Tab has a similar effect of partial reprint of the lines.

Teszko commented 7 years ago

Works on Debian linux, rxvt-unicode 9.20 This seems to be the same bug as #6

agarzola commented 7 years ago

Same happens on OS X 10.11.6.

mkermani144 commented 7 years ago

Same on Ubuntu 16.04; However, if I maximize the terminal window, the problem will no longer exist.

mangelsnc commented 7 years ago

Same as @mkermani144 an @agarzola and in addition, if I press tab key to expand the commit, just reprints again the next line.

desko27 commented 7 years ago

Hi, nice project! I have tested it in Git console for Windows (MinGW). I know the Readme says a Linux/OSX OS is required, but it seemed to me that it works just fine under MinGW except for this bug. I experience the same thing, every time I press Up/Down keys, the list of commits is reprinted leaving a duplicated first line behind.

wagnerand commented 7 years ago

At least on Mac 10.12.3 (and in my case) this is due to Apple's sed flavor behaving differently than GNU sed. If you download the GNU flavor and change the call to the executable, it works.

yggdr commented 7 years ago

This indeed fixes the main functionality (going through the list, opening them with tab), but not the reprinting and highlighting one.

Fakerr commented 7 years ago

Problem resolved on OS X with bash 4.3 or more.

yggdr commented 7 years ago

Erm, no. Why would bash fix this?

In rxvt-unicode 9.22 on FreeBSD 11.0 (using zsh and /bin/sh) Current code from master (9c53028) is still nonfunctioning on FreeBSD 11.0 with urxvt and zsh.

Fakerr commented 7 years ago

Well, upgrading to bash 4.4 in mac OS + some fixes I added resolved the issue, but I didn't try on FreeBSD to be honest. Did you try it with bash and it didn't work ? @yggdr