FalckJoshua / DIT113-System-Development-Locus-Imperium

Other
0 stars 0 forks source link

Resolve "Create a graphical user interface that displays all required information" #50 - [merged] #101

Closed FalckJoshua closed 7 months ago

FalckJoshua commented 1 year ago

In GitLab by @willand on May 6, 2023, 12:39

Merges 50-create-a-graphical-user-interface -> main

What does this MR do?

Adds a GUI for the WIO terminal displaying all important values.

Will play alerts with the buzzer if any of the values exceeds the maximum allowed.

On startup will play an image with the Locus Imperium logo and group6 watermark and the connecting progress for WiFi/mqtt.

Related issues

[Related to: #2 #4 #5 #7 #8 #16 #18 #19 #26 #31 #33]

[Closes #50]

Acceptance criteria

Authors: @vasilena @willand

FalckJoshua commented 1 year ago

In GitLab by @willand on May 6, 2023, 12:39

requested review from @cjoshua

FalckJoshua commented 1 year ago

In GitLab by @cjoshua on May 6, 2023, 12:54

Tried out the code works well, but I noticed that the bigger methods such as "updateScreen()" in "screen.cpp" could use more comments inside the method seeing how big it is. However in this case the variable names sort of makes up for it as they are self explainatory. Otherwise looks good merging!

FalckJoshua commented 1 year ago

In GitLab by @cjoshua on May 6, 2023, 12:54

enabled an automatic merge when the pipeline for d288b31e9fa96b88be80afaecf25227db80c4c14 succeeds

FalckJoshua commented 1 year ago

In GitLab by @cjoshua on May 6, 2023, 12:54

approved this merge request

FalckJoshua commented 1 year ago

In GitLab by @cjoshua on May 6, 2023, 18:17

mentioned in commit 46c3f370076ebeb05adad8be4647f1f123789b9c