Implements #54 - [merged] #102

Closed FalckJoshua closed 7 months ago

In GitLab by @willand on May 6, 2023, 13:18

Merges 54-add-missing-callback-logic-in-wio-terminal -> main

What does this MR do?

Added missing callback logic so that you can now set all the maximum values in the app instead of just maximum people.

Dependency of !37 to test easily. In the future would have branched of that branch and not main.

[Related to #14 #16]

[Closes #54]

Acceptance criteria:

[x] You can set maximum values for temperature, humidity and loudness from the app.
[x] The WIO terminal will update it's local values when the app publishes new maximum values.

In GitLab by @willand on May 6, 2023, 13:18

requested review from @cjoshua

In GitLab by @willand on May 6, 2023, 13:20

added 1 commit

In GitLab by @cjoshua on May 6, 2023, 16:58

Tried it out with the Wio combined with the app, functionality works as intended, also good commenting on the methods. Merging.

In GitLab by @cjoshua on May 6, 2023, 16:58

approved this merge request

In GitLab by @willand on May 6, 2023, 18:51

added 4 commits

d3cb6dba...46c3f370 - 3 commits from branch main
67418f50 - (Solved merge conflict) Merge branch 'main' into '54-add-missing-callback-logic-in-wio-terminal'

In GitLab by @willand on May 6, 2023, 18:51

Solved merge conflict.

In GitLab by @cjoshua on May 6, 2023, 18:51

enabled an automatic merge when the pipeline for 67418f50e132a37fcdc62e7ac3ff6ac37b3990c8 succeeds

In GitLab by @cjoshua on May 6, 2023, 18:59

mentioned in commit ba19f2f74f1e7839aab4a35bdbf2ead83994ae61