FalckJoshua / DIT113-System-Development-Locus-Imperium

Other
0 stars 0 forks source link

Redesign the mobile app with Material UI - [merged] #105

Closed FalckJoshua closed 7 months ago

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 15, 2023, 21:19

Merges 51-redesign-the-mobile-app-with-material-ui -> main

What does this MR do?

Redesign the mobile app with Material UI

Related issues

Related to #10 Closes #51

Acceptance criteria met

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 15, 2023, 21:19

requested review from @marsant

FalckJoshua commented 1 year ago

In GitLab by @marsant on May 16, 2023, 12:57

added 54 commits

Compare with previous version

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 16, 2023, 13:19

added 1 commit

Compare with previous version

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 16, 2023, 13:49

added 1 commit

Compare with previous version

FalckJoshua commented 1 year ago

In GitLab by @marsant on May 16, 2023, 14:26

The new design for the app looks great! Some functionalities are broken and should be fixed before merging

Since the re-design changed the ids of the visual elements, the tests are not running as they should be, you should change the GUI tests so they can run on the new screens.

Other than that I can't wait to see the app's new design merged when everything is fixed! 👨‍❤️‍💋‍👨

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 16, 2023, 14:27

added 1 commit

Compare with previous version

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 16, 2023, 14:29

Hello, thanks a lot for the feedback :heart_eyes:

I indeed have changed the espresso tests already :100:

FalckJoshua commented 1 year ago

In GitLab by @marsant on May 16, 2023, 14:30

enabled an automatic merge when the pipeline for c1ef21e2cac80d9753a9e25de1a0ffa2eb4c4a42 succeeds

FalckJoshua commented 1 year ago

In GitLab by @marsant on May 16, 2023, 14:30

approved this merge request

FalckJoshua commented 1 year ago

In GitLab by @marsant on May 16, 2023, 14:33

Merging now!!! :flag_ua: :handshake: :flag_cl:

FalckJoshua commented 1 year ago

In GitLab by @marsant on May 16, 2023, 14:48

mentioned in commit 6c97a729606240b2c97845ce987131e8a561cc73