FalckJoshua / DIT113-System-Development-Locus-Imperium

Other
0 stars 0 forks source link

Refactored, publishing and subscribing into one message. #55 - [merged] #106

Closed FalckJoshua closed 7 months ago

FalckJoshua commented 1 year ago

In GitLab by @cjoshua on May 16, 2023, 12:59

Merges 55-refactor-publishing-and-subscription-to-be-one-action -> main

What does this MR do?

The publish and subscribe now uses a single MQTT message and splits it into a string array, this way we increase the speed and performance instead of using multiple messages. Also deleted redundant code.

[Closes #55]

Acceptance criteria met

FalckJoshua commented 1 year ago

In GitLab by @cjoshua on May 16, 2023, 12:59

requested review from @willand

FalckJoshua commented 1 year ago

In GitLab by @willand on May 16, 2023, 16:43

Looks good, all necessary changes to increase performance and functionality remains the same. Merging.

FalckJoshua commented 1 year ago

In GitLab by @willand on May 16, 2023, 16:43

approved this merge request

FalckJoshua commented 1 year ago

In GitLab by @willand on May 16, 2023, 17:04

Waiting for #63 to be resolved before merging.

FalckJoshua commented 1 year ago

In GitLab by @willand on May 16, 2023, 18:26

added 35 commits

Compare with previous version

FalckJoshua commented 1 year ago

In GitLab by @willand on May 16, 2023, 18:26

enabled an automatic merge when the pipeline for 62ec8a3032a373102b36a22a6a951117f01281cd succeeds

FalckJoshua commented 1 year ago

In GitLab by @willand on May 16, 2023, 18:27

63 has been resolved, merging.

FalckJoshua commented 1 year ago

In GitLab by @willand on May 16, 2023, 18:39

mentioned in commit e121786938fedf8602d6f1aae220d1a953f5d651