search

FalckJoshua / DIT113-System-Development-Locus-Imperium

Other
0 stars 0 forks source link

Implements #62 - [merged] #108

Closed FalckJoshua closed 7 months ago

FalckJoshua commented 1 year ago

In GitLab by @willand on May 17, 2023, 12:17

Merges 62-static-isconnected-breaks-the-mqtt-publish-of-the-app -> main

Which bug does this MR address?

[Fixes #62]

Reworked how the BrokerConnection works Instead of each activity creating and using its own BrokerConnection object for it; there is now a universal BrokerConnection object for the entire application. This allows the tests to manipulate the connection without having static attributes which causes it to malfunction.

Related issues

[Related to #37]

FalckJoshua commented 1 year ago

In GitLab by @willand on May 17, 2023, 12:20

requested review from @vasilena

FalckJoshua commented 1 year ago

In GitLab by @vasilena on May 17, 2023, 14:26

Good approach, well thought! :clap_tone1: The improvements could be done separately, for now I'm merging this request. :smiley: :thumbsup_tone1:
Thank you for cleaning up the unused files also. :smile_cat:

FalckJoshua commented 1 year ago

In GitLab by @vasilena on May 17, 2023, 14:26

approved this merge request

FalckJoshua commented 1 year ago

In GitLab by @vasilena on May 17, 2023, 14:26

mentioned in commit 055a3b3413ee3af68c9499f609f4d04a00fc58a5