Adding small cosmetic improvements to the mobile app - [merged] #110

Closed FalckJoshua closed 7 months ago

In GitLab by @andriid on May 17, 2023, 16:42

Merges 65-add-small-cosmetic-improvements-to-the-mobile-app -> main

What does this MR do?

Added the snack-bars instead of toast messages. Also added the progress bar when connecting

Related issues

Closes #65

In GitLab by @andriid on May 17, 2023, 16:42

requested review from @vasilena

In GitLab by @andriid on May 17, 2023, 16:48

added 10 commits

74e7da65...44b0403a - 9 commits from branch main
e27e8bbf - Merge branch 'main' into '65-add-small-cosmetic-improvements-to-the-mobile-app'

Compare with previous version

In GitLab by @vasilena on May 17, 2023, 17:00

Good design change, works okay but I found an issue. The 'Connected' notification should only show when the connection is successful, not when you press 'Connect'. Also, the snack-bar needs an include.

Apart from that, the 'Progress Bar' does not have time to appear on the screen because it connects really fast. But since it is not an issue, we can leave it there just in case.

Good job! :clap_tone1:

In GitLab by @andriid on May 17, 2023, 17:00

added 1 commit

15166cbb - Added message when connection failed or succseeded #65

Compare with previous version

In GitLab by @andriid on May 17, 2023, 17:01

fixed :thumbsup_tone1:

In GitLab by @vasilena on May 17, 2023, 17:02

approved this merge request

In GitLab by @andriid on May 17, 2023, 17:04

added 1 commit

9cbeeea3 - Fixed the issue with the include #65

Compare with previous version

In GitLab by @vasilena on May 17, 2023, 17:05

enabled an automatic merge when the pipeline for 9cbeeea38203a63113c53401ce9e7842ff98ce07 succeeds

In GitLab by @andriid on May 17, 2023, 17:07

aborted the automatic merge because source branch was updated

In GitLab by @andriid on May 17, 2023, 17:07

added 1 commit

ff9a0f89 - Fixed the include with view #65

Compare with previous version

In GitLab by @vasilena on May 17, 2023, 17:07

Great!! Ready to merge :smiley: :thumbsup_tone1:

In GitLab by @vasilena on May 17, 2023, 17:07

enabled an automatic merge when the pipeline for ff9a0f89fa4d8fbc35b652a33897706be439ea13 succeeds

In GitLab by @andriid on May 17, 2023, 17:07

fixed for real

In GitLab by @andriid on May 17, 2023, 17:08

fixed for real for real

In GitLab by @vasilena on May 17, 2023, 17:10

mentioned in commit 7da18582cb763583f0e126c19445507b607f4beb

FalckJoshua / DIT113-System-Development-Locus-Imperium

Adding small cosmetic improvements to the mobile app - [merged] #110

What does this MR do?

Related issues