FalckJoshua / DIT113-System-Development-Locus-Imperium

Other
0 stars 0 forks source link

Fixed system diagram #20 - [merged] #71

Closed FalckJoshua closed 7 months ago

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 17, 2023, 16:23

Merges 20-fix-the-system-diagram -> main

We added the "Wio Terminal" component to the diagram to show how the sensors communicate with the Broker. We then connected them with the Wio Terminal, which we connected to the Broker. The updated diagram now accurately represents all parts of our system and how they interact with each other.

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 17, 2023, 16:23

requested review from @philippi

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 17, 2023, 16:25

@philippi @shariqs Please review and approve/disapprove if there are still issues so we know how to proceed.

FalckJoshua commented 1 year ago

In GitLab by @philippi on Apr 17, 2023, 20:58

Commented on 9692a6d58c9b22f3b13a866a153ea6eeb3d55e52

The publish and subscribe syntax only makes sense between the app with the broker and between the WIO terminal and the broker. The sensors do not publish or subscribe to topics. Maybe add a third type of arrow indicating data transfer, other than the mqtt payload, might be a better representation of your system. What do you think?

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 18, 2023, 14:22

added 1 commit

Compare with previous version

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 18, 2023, 14:24

Commented on 9692a6d58c9b22f3b13a866a153ea6eeb3d55e52

Is this better? :blush: @philippi

FalckJoshua commented 1 year ago

In GitLab by @philippi on Apr 18, 2023, 20:14

Commented on 9692a6d58c9b22f3b13a866a153ea6eeb3d55e52

Yes, great job! Merge request approved.

FalckJoshua commented 1 year ago

In GitLab by @philippi on Apr 18, 2023, 20:15

approved this merge request

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 18, 2023, 20:16

mentioned in commit 53c9b88ebcfc6dbf651332e24bcab24856ed02e1