FalckJoshua / DIT113-System-Development-Locus-Imperium

Other
0 stars 0 forks source link

Implementing people counting #1 - [merged] #73

Closed FalckJoshua closed 7 months ago

FalckJoshua commented 1 year ago

In GitLab by @andriid on Apr 17, 2023, 20:09

Merges 1-implement-people-counting -> main

Implemented:

Two files are created: "Ultrasonic" and "Screen" to store the newly created functions

Closes #1

FalckJoshua commented 1 year ago

In GitLab by @andriid on Apr 17, 2023, 20:09

requested review from @willand

FalckJoshua commented 1 year ago

In GitLab by @andriid on Apr 18, 2023, 14:42

requested review from @vasilena and removed review request for @willand

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 18, 2023, 15:01

added 1 commit

Compare with previous version

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 18, 2023, 15:04

I allowed myself to fix a small issue for you, otherwise everything looks okay, good variable names, comments, and overall nice work, merging. :smile: :thumbsup_tone1:

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 18, 2023, 15:05

approved this merge request

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 18, 2023, 15:05

mentioned in commit f6e68e0b4976796552321ea485dacd2d4c80bae1