FalckJoshua / DIT113-System-Development-Locus-Imperium

Other
0 stars 0 forks source link

Fixed minor issues and the main loop in 'WIOTerminal.ino' - [merged] #86

Closed FalckJoshua closed 7 months ago

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 28, 2023, 16:50

Merges 41-fix-commenting-naming-inconsistencies -> main

What does this MR do?

Changed the main loop in 'WIOTerminal.ino' to not use 'delay()', as that impacts the device. Contributor: @willand

The above-mentioned 'minor issues' include: commenting & formatting inconsistencies, typos, deleted 2 testing files that are obsolete, also deleted a few lines where delay() was used.

Closes #41

Acceptance criteria

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 28, 2023, 16:50

requested review from @willand

FalckJoshua commented 1 year ago

In GitLab by @vasilena on Apr 28, 2023, 16:56

requested review from @andriid and removed review request for @willand

FalckJoshua commented 1 year ago

In GitLab by @andriid on Apr 28, 2023, 16:57

approved this merge request

FalckJoshua commented 1 year ago

In GitLab by @andriid on Apr 28, 2023, 16:58

Looks good merging good job!!!

FalckJoshua commented 1 year ago

In GitLab by @andriid on Apr 28, 2023, 16:58

mentioned in commit 9f8aa650da6d0fe01e7b86f68f53aa37e7f575dd