FalckJoshua / DIT113-System-Development-Locus-Imperium

Other
0 stars 0 forks source link

Created a basic pipelines configuration - [merged] #88

Closed FalckJoshua closed 7 months ago

FalckJoshua commented 1 year ago

In GitLab by @carlosca on May 1, 2023, 17:58

Merges 40-create-initial-pipeline-configuration -> main

What does this MR do?

Add continue integration to the project

Related issues

[Closes #40]

Acceptance criteria met

FalckJoshua commented 1 year ago

In GitLab by @carlosca on May 1, 2023, 17:58

requested review from @andriid

FalckJoshua commented 1 year ago

In GitLab by @carlosca on May 1, 2023, 18:03

The configuration is done but in my opinion it needs some optimisation, what do you think fellow developers?

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 1, 2023, 19:32

@carlosca hmmm, good point there :thumbsup: i think it is a good idea to look more into the optimization :slight_smile:

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 1, 2023, 19:33

@carlosca good job overall

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 1, 2023, 19:34

Commented on .gitlab-ci.yml line 89

not sure if we really need linting but probably a good feature

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 1, 2023, 19:37

Commented on .gitlab-ci.yml line 51

we are doing diz every time we run tests, might be not so efficient

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 1, 2023, 19:37

Commented on .gitlab-ci.yml line 62

probably its better to check if all diz staff is installed already cos now we need to install android studio packages every time we run tests

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 1, 2023, 19:37

impressive, very nice

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 1, 2023, 19:37

approved this merge request

FalckJoshua commented 1 year ago

In GitLab by @andriid on May 1, 2023, 19:38

mentioned in commit e75170bd6d840ca79f0cfe8918e66e9492e16015