Closed FalckJoshua closed 7 months ago
In GitLab by @carlosca on May 1, 2023, 17:58
requested review from @andriid
In GitLab by @carlosca on May 1, 2023, 18:03
The configuration is done but in my opinion it needs some optimisation, what do you think fellow developers?
In GitLab by @andriid on May 1, 2023, 19:32
@carlosca hmmm, good point there :thumbsup: i think it is a good idea to look more into the optimization :slight_smile:
In GitLab by @andriid on May 1, 2023, 19:33
@carlosca good job overall
In GitLab by @andriid on May 1, 2023, 19:34
Commented on .gitlab-ci.yml line 89
not sure if we really need linting but probably a good feature
In GitLab by @andriid on May 1, 2023, 19:37
Commented on .gitlab-ci.yml line 51
we are doing diz every time we run tests, might be not so efficient
In GitLab by @andriid on May 1, 2023, 19:37
Commented on .gitlab-ci.yml line 62
probably its better to check if all diz staff is installed already cos now we need to install android studio packages every time we run tests
In GitLab by @andriid on May 1, 2023, 19:37
impressive, very nice
In GitLab by @andriid on May 1, 2023, 19:37
approved this merge request
In GitLab by @andriid on May 1, 2023, 19:38
mentioned in commit e75170bd6d840ca79f0cfe8918e66e9492e16015
In GitLab by @carlosca on May 1, 2023, 17:58
Merges 40-create-initial-pipeline-configuration -> main
What does this MR do?
Add continue integration to the project
Related issues
[Closes #40]
Acceptance criteria met
.gitlab-ci.yml
has been crated