Implements #2 - [merged] #96

Closed FalckJoshua closed 7 months ago

In GitLab by @willand on May 2, 2023, 19:14

Merges 2-give-an-alert-if-the-connection-is-lost-device -> main

What does this MR do?

Added an alert whenever the WIO terminal loses connection to the WiFi or mqtt broker.

See 6ef551e6 for more details.

NOTE: There is a library related issue with reconnection to the broker.

Due to how the library implements connection and reconnection to the broker, it will create a system wide pause until it has reconnected. This cannot be removed unless we swap library. However, as we are this far down the road it will be too much of a push back to change to another library. Thus we will have to live with this.

Related issues

[Related to: #10]

[Closes #2]

Acceptance criteria

[x] The device should detect when it's not connected to the WiFi network
[x] The device should show an alert on the screen
[x] The device should make a warning sound with a buzzer

In GitLab by @willand on May 2, 2023, 19:15

requested review from @vasilena

In GitLab by @vasilena on May 3, 2023, 20:09

Everything looks okay, good variable names, very self-explanatory, and the comments are very descriptive. Overall very good job, keep slaying :smiley: :thumbsup_tone1:

In GitLab by @vasilena on May 3, 2023, 20:09

approved this merge request

In GitLab by @vasilena on May 3, 2023, 22:46

added 2 commits

6ab94374 - Resolving a merge conflict #2
f5d8b2bb - Resolving a merge conflict #2

Compare with previous version

In GitLab by @vasilena on May 3, 2023, 22:48

added 33 commits

f5d8b2bb...8f4bca17 - 32 commits from branch main
b6224b33 - Merge branch 'main' into '2-give-an-alert-if-the-connection-is-lost-device'

Compare with previous version

In GitLab by @vasilena on May 3, 2023, 22:49

I have gone ahead and solved the merge conflicts for you, ready to merge. :handshake_tone1:

In GitLab by @vasilena on May 3, 2023, 22:50

enabled an automatic merge when the pipeline for b6224b33dc886c6dfeef620a8738b71cdc4e7995 succeeds

In GitLab by @vasilena on May 4, 2023, 13:34

mentioned in commit 9baa356910dbbef16cbcb7e7ab2291e72c72c7c7

FalckJoshua / DIT113-System-Development-Locus-Imperium