search

FalcoSuessgott / vkv

vkv enables you to list, compare, move, import, document, backup & encrypt secrets from a HashiCorp Vault KV engine
https://falcosuessgott.github.io/vkv/
MIT License
86 stars 9 forks source link

Use standard default vault client configuration #269

Closed tonglil closed 3 months ago

tonglil commented 3 months ago

Instead of checking for env vars, prefer the standard configuration and check for the use of a tokenhelper (ie existing token at ~/.vault-token).

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.05%. Comparing base (6b528bc) to head (dada752). Report is 94 commits behind head on master.

Files Patch % Lines
pkg/vault/client.go 41.17% 5 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #269 +/- ## ========================================== + Coverage 69.59% 71.05% +1.46% ========================================== Files 29 35 +6 Lines 1322 1572 +250 ========================================== + Hits 920 1117 +197 - Misses 290 315 +25 - Partials 112 140 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

FalcoSuessgott commented 3 months ago

good job! I will add one commit for updating the docs and then merge and release it along with the other PR