search

FalconChristmas / fpp

Falcon Player
http://FalconChristmas.com
Other
554 stars 193 forks source link

Allow "led-row-address-type" for FAST RPi Models. #1675

Closed mortification77 closed 5 months ago

mortification77 commented 9 months ago

FPP v7.3.1 running on RPi 4 (4MB RAM)

FPP is missing the "led-row-address-type" Option that was added to https://github.com/hzeller/rpi-rgb-led-matrix shortly after FPP was built.

Add the option to FPP.

(Edited my ORIGINAL COMMENT with accusations of disabling the feature -- sorry lol).

cpinkham commented 9 months ago

What line of FPP code are you referring to? As far as I can tell, FPP doesn't touch the row_address_type option, but that doesn't mean we disabled something. If you would like to submit a patch to support the backend and UI functionality to set this to the various options, we'd be more than willing to look at a pull request.

mortification77 commented 9 months ago

I have not dug into the code yet, but this is what I’m talking about:

From: Chris Pinkham @.> Sent: Tuesday, November 28, 2023 4:51 PM To: FalconChristmas/fpp @.> Cc: mortification77 @.>; Author @.> Subject: Re: [FalconChristmas/fpp] Allow "led-row-address-type" for FAST RPi Models. (Issue #1675)

What line of FPP code are you referring to? As far as I can tell, FPP doesn't touch the row_address_type option, but that doesn't mean we disabled something. If you would like to submit a patch to support the backend and UI functionality to set this to the various options, we'd be more than willing to look at a pull request.

— Reply to this email directly, view it on GitHub https://github.com/FalconChristmas/fpp/issues/1675#issuecomment-1830805940 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5AICVH5CZHQ373JY44KXDYGZMELAVCNFSM6AAAAAA75777YSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZQHAYDKOJUGA . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AW5AICX5SUA7RII5WYJYSJLYGZMELA5CNFSM6AAAAAA75777YSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTND7Q3I.gif Message ID: @. @.> >

mortification77 commented 9 months ago

@cpinkham I guess I should have analyzed a bit more.

I ASSumed that it was not available on RPi because it was explicitly disabled!

However looking at the plugins, it is likely due to the fact that FPP on the RPi and BBB use separate plugins for LED Panels and it was simply NEEVER ADDED when the option became available in the Lib for Pi.

I would be delighted to facilitate this!!!

mortification77 commented 9 months ago

I have a working patch to add the led-row-address-type to FPP for RPi.

@cpinkham My repo knowledge is very limited, so may need some Pull Request guidance!

darylc commented 7 months ago

@mortification77 how did you go with your pull request?

mortification77 commented 7 months ago

I got it all figured out and the pull request has been created successfully!

mortification77 commented 7 months ago

@mortification77 how did you go with your pull request?

@cpinkham and @darylc

Do I need to assign the Pull Request to someone or did I do it correctly?

mortification77 commented 7 months ago

@cpinkham and @darylc

I have updated the PR per your suggestions. It is possible I mangled the update by merging with the newer master...

I can very easily redo it from scratch, but please let me know.

I'm going to want my added feature for Holiday Season this year rather than manually updating it in my personal build. It makes updating painful.

OnlineDynamic commented 5 months ago

@mortification77 can this be closed now? Looks like PR was merged successfully... is there anything else outstanding?

mortification77 commented 5 months ago

All set.

Thanks for getting my mod in and dealing with my fumbling through my first PR.

This option that we added was added to the matrix library shortly AFTER FPP's original repo date, so that is why FPP didn't have it.

I used the matrix library in my own projects, so I know it quite well.

I believe it is the only option that FPP was missing that relates to internal panel mapping.

I will EVENTUALLY be testing out direct GPIO mapping with new style panels that I have had difficulty driving. HOWEVER, I was successful with an ESP32 with direct GPIO to HUB75 wiring, so I'm hopeful that I will be successful with the GPIO wiring per the matrix library's guide.

If more options are needed, we may revisit this again.

Thanks again!