search

FalconChristmas / fpp

Falcon Player
http://FalconChristmas.com
Other
569 stars 202 forks source link

FPP Connect Does Not Upload Correct FSEQ Size When Colorlight Card Not Initialized #2042

Open wjenkins4107 opened 2 weeks ago

wjenkins4107 commented 2 weeks ago

FPP Version and Hardware: FPP v8.2 Pi4 xLights v2024.17 Windows x64

Describe the bug and Steps to reproduce:

  1. No power to colorlight card
  2. Power up or reboot Pi4
  3. Wait for error message that the colorlight card did not initialize
  4. Upload FSEQ file using FPP Connect with FSEQ Type of V2 Sparse/zstd
  5. Upload completes FSEQ file size uploaded is not valid
  6. Power up colorlight card
  7. Reboot Pi4
  8. Upload FSEQ file using FPP Connect with FSEQ Type of V2 Sparse/zstd
  9. Upload completes
  10. FSEQ file size uploaded is correct

Expected behavior: The correct file size would be uploaded by FPP connect even if the colorlight card is not initialized

The two fseq files used in the example (Wounded Warrior Project 1.fseq and Wounded Warrior Project 2.fseq) are just copies of the original FSEQ file (Wounded Warrior Project.fseq).

Additional Attachments FPP_Logs_20241108.0014.zip

If applicable, add screenshots to help explain your problem. Screenshot 2024-11-07 184348 Screenshot 2024-11-07 191051 Screenshot 2024-11-07 191218 Screenshot 2024-11-07 191329 Screenshot 2024-11-07 191426

darylc commented 2 weeks ago

@wjenkins4107 Sounds like an xlights issue? I suspect xLights is deciding your sparse fseq doesn't need your colorlight channels or similar.

darylc commented 2 weeks ago

@wjenkins4107 you could confirm that it is an xlights side decision by changing xlights to V2 STD instead of sparse.

dkulp commented 2 weeks ago

This is working as "expected". FPP only reports the channel ranges it needs based on the outputs that can be properly initialized. If the output cannot be initialized, it won't be outputting any channel data via that output and thus would not be able to report it as a range it needs. Again, this is as expected from the FPP side.

bobreese commented 2 weeks ago

This is interesting.... My main player Pi connects to my TuneTo with Eth1 (TuneTo does not have a seperate Pi). If the TuneTo is not plugged in, the FSCQ file will not have the correct channel data?

wjenkins4107 commented 2 weeks ago

Dan,

First of all thanks for all the time and effort all of you put into the development of FPP. I understand and appreciate the initialization error messages for the colorlight card. Of course this wasn't what I "expected' since in prior versions of (xLights and FPP) an fseq V2 sparse/zstd would upload correctly irregardless of whether the colorlight card was initialized properly. Do I need to open an issue/enhancement in the xLights GitHub or am I chasing the proverbial "chicken or the egg"?

On Fri, Nov 8, 2024 at 1:50 AM Daniel Kulp @.***> wrote:

This is working as "expected". FPP only reports the channel ranges it needs based on the outputs that can be properly initialized. If the output cannot be initialized, it won't be outputting any channel data via that output and thus would not be able to report it as a range it needs. Again, this is as expected from the FPP side.

— Reply to this email directly, view it on GitHub https://github.com/FalconChristmas/fpp/issues/2042#issuecomment-2463901924, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANQJLZCTTTXM3NB7MKM74GTZ7RNJ3AVCNFSM6AAAAABRMMU772VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRTHEYDCOJSGQ . You are receiving this because you were mentioned.Message ID: @.***>