search

FalconChristmas / fpp

Falcon Player
http://FalconChristmas.com
Other
567 stars 198 forks source link

Randomize not working with nested playlists #934

Open robbiet76 opened 3 years ago

robbiet76 commented 3 years ago

FPP_Logs_20201221.0116.zip Running FPP v4.6-12-g4126f526 on RPi 3B

This is regarding the new randomize feature. Thanks for creating this as I have been hoping for this feature.

I'm having an issue with nested playlists. For my situation, I am running a main show playlist that is made up of six individual show playlists. I thought that I could use the randomize function on the main playlist and it would randomize the order of the six sub-playlists. However, what is happing is that all the sequences from all playlists are getting lumped together into one big playlist. Is this a bug or by design?

NOTE: IF YOU DO NOT ATTACH YOUR LOG FILES, THEN THERE IS A HIGHER PROBABILITY THE ISSUE WON'T BE RESOLVED. (Steps at end)

Please answer the following:

FPP Version and Hardware: Example: FPP 4.2 running on BBB

Describe the bug and Steps to reproduce: A clear and concise description of what the bug is and the steps to be taken to reproduce.

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior: A clear and concise description of what you expected to happen and why.

Additional context: Add any other context about the problem here.

Additional Attachments Please include the log files. To create the file:

  1. Open the FPP UI
  2. Open the the File Manager (Content Setup->File Manager),
  3. Select the "Logs" tab
  4. Click "zip" button.
  5. Attach to this ticket.

If applicable, add screenshots to help explain your problem.

robbiet76 commented 3 years ago

Will the Jan 7th commit fix this issue? " Add logic so PlaylistEntry* items know their parent Playlist instance"

robbiet76 commented 3 years ago

This remains an issue in master so I am bumping up.

When selecting "randomize" for a playlist, any nested playlist within will also be randomized. That seems like a bug since I have not selected those individual playlists to be randomized. Can a change be made to make sure that the randomize feature does not cascade down into nested playlists?

robbiet76 commented 3 years ago

Tested and is now working flawlessly. I'm not sure who fixed this but thanks!

robbiet76 commented 3 years ago

Still not working. Songs are still getting shuffled in all the nested playlists. Need to research further but reopening.

cpinkham commented 2 years ago

Nested playlists are included at load time, they are not included at run-time. When a playlist loads, all nested entries are loaded and merged into the parent playlist as if they were part of the parent playlist. Then the randomization kicks in. The playlist does not keep track of where an item was loaded from so it can't randomize just the parts of the parent playlist while skipping the rest. For now this is a limitation of the way nested playlists work and would require a bit of refactoring so it may take a while to achieve this level of control.

robbiet76 commented 2 years ago

OK. I get it I think. The nested playlists are handled once at the time they are loaded by the user. There is no differentiation between nested layers. Everything just becomes one big flat playlist essentially. The randomization does happen at run time, but only against the already flattened playlist. Logic would be needed to truly have nested playlists where randomization settings could apply at the individual playlist level.

robbiet76 commented 2 years ago

This issue still remains. I'm wondering if this might be fixed for the upcoming season.

cpinkham commented 2 years ago

I think our solution for this is going to be to treat nested playlists as "insert immediate" so that the randomization setting for the nested playlist is honored. We need to see if there are any issues with this before implementing it. I do think treating them as "insert immediate" would bring along a lot of nice features, but we haven't had a chance to look at it yet or determine if there are any hidden issues it might cause.

robbiet76 commented 2 years ago

Appreciate the update. This one has been on my wish list for a while but understand there are other priorities right now getting V6 ready. As always, appreciate all your work on FPP!

robbiet76 commented 2 years ago

I found a work around for this issue based on your comment about using "insert immediate". So far this works perfectly but it may still make sense to change the underlying logic so I'll leave this ticket open.

Solution: Swap out the sub-playlists and replace them all with insert immediate commands. See attached.

Ranomize_Playlists