search

FalconSocial / pre-commit-python-sorter

A pre-commit hook to sort your Python imports.
MIT License
27 stars 30 forks source link

Lost compatibility with latest release of pre-commit #18

Open Alain1405 opened 7 years ago

Alain1405 commented 7 years ago

I'm hitting issue https://github.com/pre-commit/pre-commit/issues/577 since the latest release of pre-commit, which is not backwards compatible as mentioned here

amureki commented 7 years ago

@Alain1405 there was code update, fixing this https://github.com/FalconSocial/pre-commit-python-sorter/pull/17 but release was not published. We can ask @cknv for releasing it, until then you can directly point pre-commit to use latest commit, like this:

-   repo: git://github.com/FalconSocial/pre-commit-python-sorter
    sha: b57843b0b874df1d16eb0bef00b868792cb245c2
    hooks:
    -   id: python-import-sorter
        language: system
gtback commented 7 years ago

I believe all that's needed is a new tag on GitHub. Later versions of pre-commit break when trying to run pre-commit autoupdate. ☹️

Alain1405 commented 7 years ago

@gtback @amureki's solution works as a temporary fix. @cknv could you create another release?

gtback commented 7 years ago

I just learned I can pre-commit autoupdate --bleeding-edge to get the latest (tagged or not) commit in all hook repos, which also works for pre-commit-python-sorter. But a new release would be much appreciated, @cknv ! 😀

daisylb commented 7 years ago

I've forked this repo and tagged the latest commit at https://github.com/adambrenecki/pre-commit-python-sorter, so that autoupdate still works with it without having to use --bleeding-edge on all my repos.

benjaoming commented 6 years ago

Hey @Dinoshauer or @cknv thanks for this hook!!

Likely, you can just tag latest master as 1.0.5, and then people like @adambrenecki won't have to maintain an alternative repo.

You could also grant rights to the repo to @adambrenecki :tada:

dinoshauer commented 6 years ago

Hello everyone, sorry for addressing this so late. I don't work at Falcon anymore and I don't have write access to this repo I'm afraid, so there is not much I can do for you. I will try and reach out to @cknv through other channels. In the meantime, I hope you will find a solution!

benjaoming commented 6 years ago

Shouldn't "FalconSocial" imply that you don't have to work at Falcon to be part of this? :)

Anyways, thanks @Dinoshauer - yes, there are other solutions, just seems that a lot of people have to discover the same thing over and over again.

Dunedan commented 5 years ago

There is an official isort-mirror repository for pre-commit, offering the same functionality and which is also more actively maintained and works with the latest pre-commit version: https://github.com/pre-commit/mirrors-isort/