Falconerd / discord-bot-github

GitHub repo updates displayed in Discord.
381 stars 138 forks source link

Very abusable for spam. #61

Closed fennectech closed 3 years ago

fennectech commented 6 years ago

092553ad-abab-4c87-bc66-ec885fda92e9

mpldr commented 5 years ago

Well that is not really an issue, is it? It's doing what it is told to do: notify about new stars in this case. The solution to this problem would probably be to disable notifications for new stars in the webhook settings of your repo.

fennectech commented 5 years ago

Can’t noticications for a star be sent only once for a user?

mpldr commented 5 years ago

I guess it only uses what the webhook provides. Keeping an entire database of who gave a star to what would probably be a bit expensive due to the model of Heroku.

fennectech commented 5 years ago

Howabout a running buffer. Say purge records more than 24 hours old Being able to generate one notification per 24 hours isnt nearly as abusable.

On Thu, Dec 20, 2018 at 11:44 Moritz Poldrack notifications@github.com wrote:

I guess it only uses what the webhook provides. Keeping an entire database of who gave a star to what would probably be a bit expensive due to the model of Heroku.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Falconerd/discord-bot-github/issues/61#issuecomment-449079730, or mute the thread https://github.com/notifications/unsubscribe-auth/ALZmAa_n08tp6k3kWs-lky1UAutEj8wFks5u68yDgaJpZM4Wd7AF .

-- FennecTECH

Falconerd commented 3 years ago

If you are getting a lot of stars you can disable the payload with this. image