Open BardezAnAvatar opened 1 year ago
Hi Rimfactory Maintainer here
I see that you have a patch for ProjectRimFactory.SAL3.UI.ITab_SAL3Bills
https://github.com/Falconne/ImprovedWorkbenches/blob/9c3e0dda1a897f500c0712e75527aca1c2b67e35/src/ImprovedWorkbenches/Main.cs#L91
there is a additional ITab specifically for the Plasma Drill
called ProjectRimFactory.AutoMachineTool.ITab_Bills2
The issue likely is that there is no patch for that one.
I think i will recheck if that additional ITab is necessary or not and update you here.
I was able to remove the additional ITab in https://github.com/zymex22/Project-RimFactory-Revived/commit/ccda0c5c93f59970eecc49a8a05ecf715763688f
This change did not break any of the existing compatibility, however the Plasma Drill
ProjectRimFactory.AutoMachineTool.Building_Miner
is still not supported by your Patch.
this might be the case as you appear to check for the Building type https://github.com/Falconne/ImprovedWorkbenches/blob/9c3e0dda1a897f500c0712e75527aca1c2b67e35/src/ImprovedWorkbenches/Main.cs#L96-L97
With the mentioned Change I have introduced the IBillTab
Interface. maybe you can used that instead or otherwise update the patch.
I have submitted a PR for this issue.
Root cause: From what I can tell, it was getting into a code path if it was a PRF building and then subsequent PRF exception cases were not being checked, causing half-functional code patches. The existing captured re-order collection was invalid and the code to look for a collection to re-order just reverts to the colonist bar?
@Sn1p3rr3c0n: The patch I have looks rather lazy, checking multiple types. You mention IBillTab
and that looks like it would be a better candidate once your PR is completed and the mod gets published. In the interim: is there a better base type that we could use that encompasses all PRF buildings that have bill tabs, but not any buildings lacking one?
Describe the bug
The Plasma Drill from Project RimFactory Revived cannot re-order any of its bills when installed along side Better Workbench Management mod. When a bill is selected ON ONLY THIS STATION, it instead re-orders... colonists instead.
To Reproduce Reproducibility: ? Steps to reproduce the behavior:
Expected behavior Bills should be movable
Actual Behavior Bills will not be reorderable. Instead, the bill selection appears to redirect to colonists. See screenshots that show cursor over bills, but have floating colonist pawns dragged instead.
Screenshots
![screenshot9](https://user-images.githubusercontent.com/39980629/222502925-2cc6d7ff-f94b-40d4-900f-ce6024fb8ddf.png)
Rimworld (please complete the following information):
Modlist (please complete the following information):
Additional context Other workbenches and machines within PRF work properly (such as assemblers); I want to say, anecdotally, that I used to see an index out of bounds of array error message when dragging bills on this station but I am not able to reproduce that error reporting behavior at this time.
Link to bug report over at PRF repo