search

Falcosc / enable-loudness-equalisation

automatically adds and enables loudness equalisation to any playback device
GNU General Public License v3.0
43 stars 9 forks source link

Main Branch .PS1 issue #23

Closed ArtIsWar closed 6 months ago

ArtIsWar commented 6 months ago

Rewording to clarify:

The current script in the main branch does not work - whenever I run the script on an audio device, Powershell shows "importing..." etc but the enhancements tab is not actually added. When I run the script from here, it works properly.

Falcosc commented 6 months ago

Have you tried my fix from 8 hours ago? If yes, please share %TMP%/SoundEnhancementsTMP.reg result from the old and the new version. After the fix, they are equal on my system.

ArtIsWar commented 6 months ago

Reposted for clarification before retesting the main or checking update. Apologies. Main branch .ps1 functions now. Thank you!

Falcosc commented 6 months ago

There was a strange bug with "reg query", it took forever to return the result despite only searching a pretty narrow segment of the registry. I don't know what was happening on other people's computers, but the powershell cmdlet solution of the same search expression did work around this issue. Since the response is a bit differently, it did break the registry import.

How did you know that something was wrong? Do you download it regularly to check for new stuff?

ArtIsWar commented 6 months ago

I keep the invoke command handy to enable on systems that don't have LEQ available for gaming. Tried it and it didn't function, tried troubleshooting, found the other branch and it worked. This is wonderfully helpful work, so I figured I'd contribute any issues I found.

Cheers!

Falcosc commented 6 months ago

Wasn't aware that this option is missing on gaming systems. I usually see it missing on HDMI of Intel Graphics. And since you can't amplify monitor speakers a lot, it is impossible to hear audio streams with not enough gain. And since HDMI audio devices sometimes get reinstalled, it was a pain to always put these entries in the random audio device id folder. But nobody is using monitor speakers for gaming.

ArtIsWar commented 6 months ago

Most Realtek USB 2.0 labeled drivers can't be rolled back to a generic driver with the enhancements tab, where your script fixes entirely!

ArtIsWar commented 6 months ago

Fun fact, with Equalizer APO installed FIRST as LFX/GFX, you can enable loudness EQ on a virtual cable, effectively adding LEQ to any system. Thank you again for all your work!