search

FalkTannhaeuser / python-onvif-zeep

ONVIF Client Implementation in Python 2+3 (using https://github.com/mvantellingen/python-zeep instead of suds as SOAP client)
MIT License
428 stars 140 forks source link

Wrong imports after merge pull request #10 from lucaszanella/zeep #16

Open iomihai opened 6 years ago

iomihai commented 6 years ago

Hello,

In onvif/client.py at lines 15-16 the imports do not work in python3. 

from exceptions import ONVIFError
from definition import SERVICES

should be reverted to

from onvif.exceptions import ONVIFError
from onvif.definition import SERVICES

Thank you.

tarelda commented 6 years ago

Technically speaking you are not quite right too. I assume that orginal intention was to import modules relatively so to fix it should be:

from .exceptions import ONVIFError from .definition import SERVICES

iomihai commented 6 years ago

That would work better, I was just refering to the original imports that were replaced by that pull request.