FalkorDB / falkordb-omnistrate

Other
3 stars 1 forks source link

Add ability to upload config file for redis / falkordb module #56

Closed dudizimber closed 2 months ago

dudizimber commented 3 months ago

@gkorland @AviAvni We discussed allowing users to upload their custom config file to change the database's parameters. I was thinking about it, and I'm not sure it's a good idea to do that as a config file, since we could only validate this file when the server spins up, which takes several minutes, and then we'd have to make somehow the user know that the config file is invalid.

I'm thinking about 2 options:

What do you think?

dudizimber commented 3 months ago

@swilly22 Which configuration parameters do we want to allow users to change?

swilly22 commented 3 months ago

This is what I think should be configurable by the user

AviAvni commented 3 months ago

@swilly22 can you also add valid range of value?

swilly22 commented 3 months ago

@AviAvni Sure, I've updated to former comment to include default values which I think are reasonable.

dudizimber commented 3 months ago

@swilly22 can you add also a minimum and maximum, please?

swilly22 commented 3 months ago

@dudizimber, Original comment updated to include [min-max] ranges.