Closed swilly22 closed 5 months ago
The changes introduce support for Redis Sentinel connections in the FalkorDB library. This involves importing necessary Sentinel components, adding logic to detect and handle Sentinel connections in the __init__
and from_url
methods of the FalkorDB
class, and creating Sentinel connections from Redis connections when needed.
Files | Change Summary |
---|---|
falkordb/falkordb.py | Added imports for Sentinel , modified __init__ and from_url methods to handle Sentinel connections. |
falkordb/sentinel.py | Introduced functions to detect Sentinel connections and create them from Redis connections. |
sequenceDiagram
participant User
participant FalkorDB
participant Sentinel
User->>FalkorDB: Initialize connection (URL)
FalkorDB->>Sentinel: Check if URL is Sentinel
alt If Sentinel
Sentinel-->>FalkorDB: Return Sentinel connection
FalkorDB->>User: Return Sentinel connection
else If not Sentinel
FalkorDB->>User: Return regular connection
end
In the realm of code so bright and keen,
FalkorDB meets Sentinel, unseen.
Connections now with grace they bind,
Masters and nodes, all intertwined.
With every line and byte so fine,
A database dance, a sentinel sign.
🎉🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 29.62963%
with 19 lines
in your changes missing coverage. Please review.
Project coverage is 92.58%. Comparing base (
b3e6927
) to head (7821563
).
Files | Patch % | Lines |
---|---|---|
falkordb/sentinel.py | 25.00% | 15 Missing :warning: |
falkordb/falkordb.py | 42.85% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
29
Summary by CodeRabbit