Open MuhammadQadora opened 2 weeks ago
The changes to the FalkorDB
class in falkordb/falkordb.py
include the addition of a decode_responses
parameter to the __init__
method, which allows for flexible response decoding from Redis. Several instance variables are initialized to manage configuration parameters. A new method, get_replica_connections
, is introduced to retrieve replica connections based on Sentinel or Cluster modes, enhancing the class's functionality related to connection management and usability.
File | Change Summary |
---|---|
falkordb/falkordb.py | - Added decode_responses parameter to __init__ method with default value True . |
- Initialized self.cluster_flag based on connection mode. |
|
- Introduced get_replica_connections method for retrieving replica connections in Sentinel and Cluster modes. |
__init__
method of the FalkorDB
class in both PRs involve updates to method signatures, indicating a direct relationship in how the class's initialization parameters are being modified.In the realm of code, where rabbits hop,
FalkorDB's changes make the data swap.
With replicas found, and responses decoded,
Our connections are strong, and bugs corroded.
Hooray for the tweaks, let the data flow free,
A hop and a skip, oh, what joy it will be! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 11.11111%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 92.01%. Comparing base (
d0671f6
) to head (dd8a4ad
).
Files with missing lines | Patch % | Lines |
---|---|---|
falkordb/falkordb.py | 11.11% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
fix #71
Summary by CodeRabbit
New Features
Improvements