search

Fallen-Breath / PCRC

PyCraft based Replay Client
Apache License 2.0
140 stars 17 forks source link

Support authlib-injector and display all part of skin #8

Open Sciroccogti opened 4 years ago

Sciroccogti commented 4 years ago

感谢 @Merrrg1n

Fallen-Breath commented 4 years ago

Are you able to maintain this part of code if pycraft upgrades and changes related codes in the future?

Fallen-Breath commented 4 years ago

The part of ClientSettingsPacket code is hard-coded, which is not good in my opinion. Things like client view distance or something will somehow affect the recording

Sciroccogti commented 4 years ago

Are you able to maintain this part of code if pycraft upgrades and changes related codes in the future?

Sadly I'm not sure, but I'll try, so maybe you'd better not to merge into master. I just hope this branch may help those who are using PCRC with authlib-injector.

Sciroccogti commented 4 years ago

The part of ClientSettingsPacket code is hard-coded, which is not good in my opinion. Things like client view distance or something will somehow affect the recording

Maybe it can be configured with conf.json? Currently I haven't seen any codes in PCRC to configure it, so I guess these parameters are set as default now. However I didn't find out which is the default value of view distance.

I'll try to make them editable as long as I have time.

Sciroccogti commented 3 years ago

Test is REQUIRED before merging!

I tried to do some easy things on reading conf.json, but do not have a chance to test it since our server is paused (due to Graduate Entrance Exam). And I also cannot decide which setting should be added into the conf.json.