search

Fallen-Breath / tweakermore

A collection of client-side tweak kits to enhance your Minecraft game experience. Tweak Minecraft and beyond!
GNU Lesser General Public License v3.0
168 stars 13 forks source link

Malilib-ShulkerBoxPreviewSupportEnderChest does not work with MiniHUD/Servux #80

Open kkellogg378 opened 1 week ago

kkellogg378 commented 1 week ago

Bug description

MiniHUD now has an inventory sync protocol for servers with the mod Servux. With this, the shulker box / entity inventory preview stuff was moved from Tweakaroo to MiniHUD. Currently, TweakerMore's Malilib-ShulkerBoxPreviewSupportEnderChest only supports the shulker box preview on Tweakaroo, not the one on MiniHUD, and as a result ender chests are shown as empty on servers.

Note that ender chest data is indeed synced with Servux, as the InventoryPeek for entities works on players and shows their ender chest data just fine

Steps to reproduce

  1. Download latest MiniHUD (minihud-fabric-1.21.1-0.32.50.jar) and latest TweakerMore
  2. Join a 1.21.1 server with Servux installed
  3. Enable Malilib-ShulkerBoxPreviewSupportEnderChest in TweakerMore settings
  4. Try to preview ender chest inventory

Expected behavior

Expected: Ender chest inventory shown

Actual behavior

Actual: Ender chest inventory shows as empty due to not receiving inventory data via Servux

Relevant logs

No response

Minecraft version

1.21.1

TweakerMore version

3.21.0

Other information

No response

Check list

Edit: forgot to finish the Actual Behavior section

kkellogg378 commented 5 days ago

Bumping

Fallen-Breath commented 4 days ago

Please explain what step 4, "Try to preview ender chest inventory", means

kkellogg378 commented 3 days ago

Hover mouse over an ender chest in an inventory

Edit: removed irrelevant photo

Fallen-Breath commented 3 days ago

Please explain what step 4, "Try to preview ender chest inventory", means, including the option name you are using in minihud. "Hover mouse over an ender chest in an inventory" results in nothing with freshly installed tweakermore + minihud

Do not use options from tweakeroo since it's unrelated to the issue description. Also, please make sure the "actual behavior" section is filled correctly

kkellogg378 commented 3 days ago

MiniHUD: v0.32.51

TweakerMore: v3.21.0

Servux: v0.3.8

Steps to reproduce

Expected behavior: tooltip with ender chest inventory appears

Actual behavior: normal vanilla tooltip appears

Fallen-Breath commented 1 day ago

So this is unrelated to the inventory sync protocol from minihud. It's just TweakerMore not supporting the SHULKER_BOX_PREVIEW feature from MiniHud since mc1.20.6+ (see also https://github.com/sakura-ryoko/minihud/commit/79cf123fc081f52906fe42c3afd5afe42ae9de91#diff-1732f51007b2e8ea89d242775516cbb723c4da7308fd67d953b93a0a15e6af78R156, the same change as tweakeroo)