search

FallenMoonNetwork / CanaryMod

Server administration mod and API for Minecraft beta multiplayer server
http://canarymod.net
GNU Lesser General Public License v3.0
20 stars 14 forks source link

Shift clicking an item to a villager crashes client #80

Closed BluXDragon closed 11 years ago

BluXDragon commented 11 years ago 
2012-12-13 00:08:25 [WARNING] Failed to handle packet for BluXDragon/192.168.1.6: java.lang.ClassCastException: OSlot cannot be cast to OSlotMerchantResult
java.lang.ClassCastException: OSlot cannot be cast to OSlotMerchantResult
        at OContainerMerchant.b(OContainerMerchant.java:86)
        at OContainer.a(OContainer.java:114)
        at ONetServerHandler.a(ONetServerHandler.java:766)
        at OPacket102WindowClick.a(SourceFile:31)
        at OTcpConnection.b(SourceFile:349)
        at ONetServerHandler.d(ONetServerHandler.java:44)
        at ONetworkListenThread.b(SourceFile:39)
        at ODedicatedServerListenThread.b(SourceFile:30)
        at OMinecraftServer.r(OMinecraftServer.java:472)
        at ODedicatedServer.r(SourceFile:248)
        at OMinecraftServer.q(OMinecraftServer.java:383)
        at OMinecraftServer.run(OMinecraftServer.java:322)
        at OThreadMinecraftServer.run(SourceFile:856)
2012-12-13 00:08:26 [INFO] /96.236.19.200:58573 lost connection

Edit: Also wtf external IP losing connection? Confirmed Canary bug. Does not happen on vanilla.

14mRh4X0r commented 11 years ago

The external IP losing connection was possibly a client that sent a 0xFE package. I will look into this.

gregcarlin commented 11 years ago

Can you tell me if this still happens after my last commit? For some reason I can't shift click into villagers.

BluXDragon commented 11 years ago

Crash no longer occurs, but shift-clicking the item does not move it to the villager.

gregcarlin commented 11 years ago

You son of a bitch... I just spent over an hour trying to figure this out, when I tried it in vanilla, it didn't work either. :confused:

BluXDragon commented 11 years ago

...I swear I said unconfirmed if vanilla for that part... Sorry D: I blame paint fumes.