FallenMoonNetwork / CanaryMod

Server administration mod and API for Minecraft beta multiplayer server
http://canarymod.net
GNU Lesser General Public License v3.0
20 stars 14 forks source link

request - gui additions #95

Closed spenk closed 11 years ago

spenk commented 11 years ago

it would be nice after we got alot of new inventory additions if we could also get gui additions like

i hope you could add some of them :)

ayyron-dev commented 11 years ago

Mebbe ill lok at this tom. The diplomats issues take pre edence though because they're bugs

14mRh4X0r commented 11 years ago
  • set the name of a chest

That one's already in there.

  • [...] with a method to put max enchanting level

I don't really see the use of this, and you can always limit a player's XP. If you can give us a proper use case though, we will consider it.

As for the rest, I'm not quite sure whether this is something that should be in Canary itself.

spenk commented 11 years ago

eh somners, not sure if your keyboard is broken or your were really tired when you wrote it

14mR4X0r i think they should be canary things since its possible using vanilla code (notchian) if canary just offers the methods it would be quite fancy instead of using some external source

BluXDragon commented 11 years ago

Remote chests and the like is false, spenk. You say it can be done via Notchian, but this isn't true. At least I have yet to see it successful. It can be "sort of" done with packet sending, however these windows do NOT achieve anything, eg, if you craft something in a remote craft window, the created item will vanish.

Remote enderchest could be possible. Not sure.

darkdiplomat commented 11 years ago

@BluXDragon Actually it can be done (not perfectly though)

While it is true that windows themselves don't do anything, you can remotely access a container with a GUI window opening up Client side. You can do it by calling the methods in OEntityPlayerMP for inventories and providing a real container to be accessed (not just sending a packet to fake it). I've had some successful tests with this, though its not 100% perfect and fails to open the window quite often. (chunk not loaded, windows not registering as closed, etc...) I was able to craft items remotely and not have them disappear.

All in all, I don't recommend adding this into Canary itself due to the weird behaviors that can result.

BluXDragon commented 11 years ago

Interesting. I was under the impression that it would not accept results when the container in question isn't within a certain range.

14mRh4X0r commented 11 years ago

Marking as "wontfix" and closing.