Fallenbagel / jellyseerr

Fork of overseerr for jellyfin support.
https://docs.jellyseerr.dev/
MIT License
3.95k stars 250 forks source link

Movies in collections not being detected #474

Closed colfin22 closed 1 year ago

colfin22 commented 1 year ago

Description

I have 3 libraries, TV shows, Movies and Collections but no movies that are in collections are being marked as available. Should Collections be a library item at all? It's not very clear. I've removed Collections to see what the results are after a scan

Originally posted by @colfin22 in https://github.com/Fallenbagel/jellyseerr/discussions/472

Version

1.6.0

Steps to Reproduce

I have 3 libraries, TV shows, Movies and Collections but no movies that are in collections are being marked as available. I've un-selected the collections library and forced a scan but the issue still persists. See uploaded screenshot, all of these movies are in my library but as they are in a collection none are marked as available. Logs of the last scan with collections enabled attached, you can see from the scan it's not detecting any of the movies in the Fast collection

Screenshots

Screenshot 2023-09-10 113454

Logs

2023-09-10T10:57:01.790Z [debug][Jellyfin Sync]: Title already exists and no new media types found A Fall from Grace 
2023-09-10T10:57:01.791Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fahrenheit 451 
2023-09-10T10:57:01.795Z [debug][Jellyfin Sync]: Title already exists and no new media types found False Positive 
2023-09-10T10:57:01.804Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Eyes of Tammy Faye 
2023-09-10T10:57:01.808Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fahrenheit 451 
2023-09-10T10:57:01.810Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fall 
2023-09-10T10:57:01.813Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fame 
2023-09-10T10:57:01.815Z [debug][Jellyfin Sync]: Title already exists and no new media types found Falling Down 
2023-09-10T10:57:01.820Z [debug][Jellyfin Sync]: Title already exists and no new media types found Falling Inn Love 
2023-09-10T10:57:05.988Z [debug][Jellyfin Sync]: Title already exists and no new media types found Famous and Fatal 
2023-09-10T10:57:05.992Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Family Stone 
2023-09-10T10:57:05.995Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Family I Had 
2023-09-10T10:57:05.995Z [debug][Jellyfin Sync]: Title already exists and no new media types found Far from the Madding Crowd 
2023-09-10T10:57:06.017Z [debug][Jellyfin Sync]: Title already exists and no new media types found Family Man, Family Murderer: An ID Murder Mystery 
2023-09-10T10:57:06.036Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fargo 
2023-09-10T10:57:06.038Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Farewell 
2023-09-10T10:57:06.056Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fantastic Four 
2023-09-10T10:57:06.061Z [debug][Jellyfin Sync]: Title already exists and no new media types found Family Guy Presents: It's a Trap! 
2023-09-10T10:57:06.063Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fantastic Voyage 
2023-09-10T10:57:06.064Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fanny and Alexander 
2023-09-10T10:57:06.072Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fantastic Planet 
2023-09-10T10:57:06.074Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fantasy Island 
2023-09-10T10:57:06.074Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Fanatic 
2023-09-10T10:57:06.074Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fast & Furious Presents: Hobbs & Shaw 
2023-09-10T10:57:06.111Z [debug][Jellyfin Sync]: Title already exists and no new media types found Far from the Tree 
2023-09-10T10:57:10.229Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fatal Affair 
2023-09-10T10:57:10.324Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fatale 
2023-09-10T10:57:10.332Z [debug][Jellyfin Sync]: Title already exists and no new media types found Father of the Bride 
2023-09-10T10:57:10.333Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fear and Desire 
2023-09-10T10:57:10.333Z [debug][Jellyfin Sync]: Title already exists and no new media types found Father Soldier Son 
2023-09-10T10:57:10.335Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Father 
2023-09-10T10:57:10.335Z [debug][Jellyfin Sync]: Title already exists and no new media types found Faults 
2023-09-10T10:57:10.336Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Fault in Our Stars 
2023-09-10T10:57:10.344Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fast Times at Ridgemont High 
2023-09-10T10:57:10.344Z [debug][Jellyfin Sync]: Title already exists and no new media types found Father Stu 
2023-09-10T10:57:10.345Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fear and Loathing in Aspen 
2023-09-10T10:57:10.346Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fatherhood 
2023-09-10T10:57:10.354Z [debug][Jellyfin Sync]: Title already exists and no new media types found Father Christmas Is Back 
2023-09-10T10:57:10.361Z [debug][Jellyfin Sync]: Title already exists and no new media types found Father of the Year 
2023-09-10T10:57:10.363Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Favourite 
2023-09-10T10:57:10.369Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fatman 
2023-09-10T10:57:10.372Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fatima 
2023-09-10T10:57:10.373Z [debug][Jellyfin Sync]: Title already exists and no new media types found Father of the Bride 
2023-09-10T10:57:10.374Z [debug][Jellyfin Sync]: Title already exists and no new media types found Faster 
2023-09-10T10:57:10.374Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fast Color 
2023-09-10T10:57:14.508Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Festival 
2023-09-10T10:57:14.510Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Fifth Element 
2023-09-10T10:57:14.511Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fight Club 
2023-09-10T10:57:14.516Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Field 
2023-09-10T10:57:14.519Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fences 
2023-09-10T10:57:14.530Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Field 
2023-09-10T10:57:14.530Z [debug][Jellyfin Sync]: Title already exists and no new media types found The Fear of 13 
2023-09-10T10:57:14.531Z [debug][Jellyfin Sync]: Title already exists and no new media types found Ferris Bueller's Day Off 
2023-09-10T10:57:14.537Z [debug][Jellyfin Sync]: Title already exists and no new media types found Ferry 
2023-09-10T10:57:14.548Z [debug][Jellyfin Sync]: Title already exists and no new media types found Ferdinand 
2023-09-10T10:57:14.551Z [debug][Jellyfin Sync]: Title already exists and no new media types found Filth 
2023-09-10T10:57:14.551Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fear of Rain 
2023-09-10T10:57:14.562Z [debug][Jellyfin Sync]: Title already exists and no new media types found Feel the Beat 
2023-09-10T10:57:14.565Z [debug][Jellyfin Sync]: Title already exists and no new media types found A Few Good Men 
2023-09-10T10:57:14.565Z [debug][Jellyfin Sync]: Title already exists and no new media types found Field of Dreams 
2023-09-10T10:57:14.566Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fighting with My Family 
2023-09-10T10:57:14.567Z [debug][Jellyfin Sync]: Title already exists and no new media types found Fear and Loathing in Las Vegas 
2023-09-10T10:57:14.650Z [debug][Jellyfin Sync]: Title already exists and no new media types found Feed

Platform

desktop

Device

Docker

Operating System

Ubuntu 22.04 host

Browser

Firefox

Additional Context

No response

Code of Conduct

Fallenbagel commented 1 year ago

Yeah it's a bug with the jellyfin api we use. There's a workaround for this. Do not use automatically collection option in the library of jellyfin and instead use tmdb boxsets plugin (you'll need to remove all your current collections and do a sync before you turn on this plugin)

colfin22 commented 1 year ago

Sorry, I'm not clear on my actions? I delete the collections library item in jellyfin, sync this app, then install and enable tmdb boxsets in jellyfin and run a scan to get my collections library back?

Fallenbagel commented 1 year ago

Sorry, I'm not clear on my actions? I delete the collections library item in jellyfin, sync this app, then install and enable tmdb boxsets in jellyfin and run a scan to get my collections library back?

Remove all your collections. Sync in jellyseerr. Install tmdb boxsets and let it handle collections

colfin22 commented 1 year ago

Thanks, underway

colfin22 commented 1 year ago

Yeah, that worked. Thanks

ristein commented 1 year ago

Remove all your collections. Sync in jellyseerr. Install tmdb boxsets and let it handle collections

This is working for me.

But the tmdb boxsets plugin only shows collections in another library called collections. I liked the functionality of grouping movies into collections in every library. Would be great to have a fix for this some day

Fallenbagel commented 1 year ago

Remove all your collections. Sync in jellyseerr. Install tmdb boxsets and let it handle collections

This is working for me.

But the tmdb boxsets plugin only shows collections in another library called collections. I liked the functionality of grouping movies into collections in every library. Would be great to have a fix for this some day

You literally can do that... Tmdb boxsets or automatic collection both will create a collection folder. But you CAN still display collections in its own library. I'm literally doing that.

Screenshot_20231110_221443_Jellyfin Screenshot_20231110_221502_Jellyfin

ristein commented 1 year ago

you are right. I just tested this by downloading movies from one collection I did not have before and Overseerr finds them even though they are inside a collection as soon as the second movie arrives. Awesome. I was just confused and did not expect this to be working because now I have the same setup as before when it wasn't working.

allthesebugsv2 commented 11 months ago

So I have always been using TMDB Boxsets for collections (and never JF's native feature); still any movie in a collection was not picked up.

I had the library display option "Group films into collections" enabled as shown by @Fallenbagel. I then disabled this option, did a re-scan of the library in jfseerr, the number of movies during the scan went up and every movie was added properly.

However, I prefer this option to be enabled. As soon as I enable the option again, the number of movies during a scan goes down again. The movies inside collections still remain in the library but I think this is only because media availability is not yet merged (https://github.com/Fallenbagel/jellyseerr/pull/522). I fear that as soon as that feature is merged, the movies from collections will be gone again with "Group films into collections" enabled

Fallenbagel commented 11 months ago

So I have always been using TMDB Boxsets for collections (and never JF's native feature); still any movie in a collection was not picked up.

I had the library display option "Group films into collections" enabled as shown by @Fallenbagel. I then disabled this option, did a re-scan of the library in jfseerr, the number of movies during the scan went up and every movie was added properly.

However, I prefer this option to be enabled. As soon as I enable the option again, the number of movies during a scan goes down again. The movies inside collections still remain in the library but I think this is only because media availability is not yet merged (https://github.com/Fallenbagel/jellyseerr/pull/522). I fear that as soon as that feature is merged, the movies from collections will be gone again with "Group films into collections" enabled

You could test out with that pr. But the thing is, I also have that option enabled: Screenshot_20240105_005752_Jellyfin.jpg

allthesebugsv2 commented 11 months ago

Yes, I saw that in your post. However, I can reproduce this by

Disabling "Group films into collections" allows for the movie to be re-added again. As I said I've only ever used the TMDB Boxset plugin. To debug I have uninstalled it, removed the existing collections library and then re-installed the plugin. Still, behavior is as described above. I am using the latest stable in docker.

Fallenbagel commented 11 months ago

Yes, I saw that in your post. However, I can reproduce this by

  • disable "Group films into collections"
  • all movies are added
  • remove the data for a single movie in a collection from jfseerr
  • enable "Group films into collections"
  • re-scan the library
  • the movie is not re-added

Disabling "Group films into collections" allows for the movie to be re-added again. As I said I've only ever used the TMDB Boxset plugin. To debug I have uninstalled it, removed the existing collections library and then re-installed the plugin. Still, behavior is as described above. I am using the latest stable in docker.

Unfortunately I have tried that too and can't reproduce it. I am on develop tag though

allthesebugsv2 commented 11 months ago

Unfortunately I have tried that too and can't reproduce it. I am on develop tag though

Okay, then I'll try again once the next update is released. And I really appreciate your help, thanks!

Fallenbagel commented 7 months ago

:tada: This issue has been resolved in version 1.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: