Fallenbagel / jellyseerr

Fork of overseerr for jellyfin support
MIT License
3.16k stars 198 forks source link

[Feature Request] Forward Proxy option #491

Open spyhuntergenral opened 9 months ago

spyhuntergenral commented 9 months ago

Description

Currently all outbound internet requests follow the default network path,

Desired Behavior

Add the ability to set proxy options in the GUI settings

i.e external web requests to "api.themoviedb.org" would get proxied via a network proxy (http/https or socks5)

Additional Context

No response

Code of Conduct

Fallenbagel commented 9 months ago

If on docker you can set the proxy through the environment (although some people had issues with it, from my testings http/https/socks5) worked pretty well

spyhuntergenral commented 9 months ago

Yes running in docker, version: 1.7.0

i gave that a go, I'm assuming you meant something like this in the compose file:

   environment:
      HTTP_PROXY: 'http://xxx.xxx.xxx.xxx:xxxx'
      HTTPS_PROXY: 'http://xxx.xxx.xxx.xxx:xxxx'
      NO_PROXY: 'localhost,127.0.0.0/8,10.0.0.0/8,172.16.0.0/12,192.168.0.0/16'

||

    environment:
      HTTP_PROXY: 'socks5://xxx.xxx.xxx.xxx:xxxx'
      HTTPS_PROXY: 'socks5://xxx.xxx.xxx.xxx:xxxx'
      NO_PROXY: 'localhost,127.0.0.0/8,10.0.0.0/8,172.16.0.0/12,192.168.0.0/16'

didn't like it...

i got these errors from jellyseer: when using socks {"errorMessage":"protocol mismatch"} when using http/s: {"errorMessage":"Request failed with status code 405"}

and regardless if any proxy env's where set i lost connection to my jellyfin,radarr and sonarr, so its not respecting the no_proxy env

I have both radarr and sonarr + a few other things pointed at this proxy and they all work ok.

Am interested in knowing how you have yours setup??

Fallenbagel commented 9 months ago

That's not how you set it

environment:
     HTTPS_PROXY=http://192.168.100.1:8000

Should be an = sign

spyhuntergenral commented 9 months ago

What?? that's just yaml syntax?

Fallenbagel commented 9 months ago

What?? that's just yaml syntax?

This is the environment block. In this block its an equal sign to set environment variables. Maybe you might want to read the docs

Or check this https://github.com/Fallenbagel/jellyseerr/issues/343#issuecomment-1738877516

spyhuntergenral commented 9 months ago

I see, Thanks for linking that other issue, it was the '' causing my problems.

I still suggest having proxy settings at the application level, like the other *arrs. makes for a more uniformed config experience. never the less is working now.